◐ Shell
reader mode source ↗
Skip to content

Fix syntax highlighting for short and Short types#1260

Merged
catilac merged 2 commits into
processing:mainfrom
aj-m:fix-syntax-datatype-short
Oct 8, 2025
Merged

Fix syntax highlighting for short and Short types#1260
catilac merged 2 commits into
processing:mainfrom
aj-m:fix-syntax-datatype-short

Conversation

@aj-m

@aj-m aj-m commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Resolves: #1259
Changes:

  • keywords.txt: register short and Short keywords so they're correctly highlighted as datatypes.

Tests: I don't think they apply here, but it looks and runs right for me.
image

catilac
catilac requested changes Oct 7, 2025
View reviewed changes

@catilac catilac left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I don't believe that we currently support the Short datatype. Can you remove the Short keyword addition?

Everything else works.

As for Short: You are welcome to create an issue around supporting the Short class. It will take more effort than adding a keyword to keywords.txt

@aj-m

aj-m commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Done. I assumed it made sense to add Short alongside short since it's a standard Java type is all.

@catilac

catilac commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Thank you so much @aj-m! That is a totally understandable assumption to make. Approved 🎉 🙌🏽

Hide details View details @catilac catilac merged commit 5dc52be into processing:main Oct 8, 2025
6 checks passed
@catilac

catilac commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

@all-contributors please add @aj-m for code

@allcontributors

allcontributors Bot commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

@catilac

@aj-m already contributed before to code

@aj-m aj-m deleted the fix-syntax-datatype-short branch October 8, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catilac catilac catilac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

short data type not being highlighted in text editor

2 participants

@aj-m @catilac