Add PR artifact uploads and comments#1401
Conversation
Update the build workflow to handle pull request runs: make the main artifact upload conditional (skip for pull_request), add a separate upload step for PR artifacts with longer retention, and post a sticky PR comment containing a download link. Also adjust workflow permissions to allow pull-request write access and include updated artifact paths.
|
@SableRaf https://github.com/marocchino/sticky-pull-request-comment?tab=readme-ov-file#error-resource-not-accessible-by-integration it does need some configuration on Processings side. A cool alternative could also be to use the |
Sorry, something went wrong.
Add PR-facing comments and artifact wiring to the CI workflow. Post a sticky comment after Gradle tests to indicate artifacts availability, add an upload-artifact step with an id, and update the sticky-comment step to use the artifact output URL (steps.upload-artifact.outputs.artifact-url) and a consistent header. These changes make build artifacts discoverable on pull requests.
catilac
left a comment
There was a problem hiding this comment.
ahh okay! thank you for fixing this. in general if something is ready for review, please do tag me! i'll go ahead and merge this in
Sorry, something went wrong.
@Stefterv though i see there is a failing check. lmk when ready to merge! |
Sorry, something went wrong.
|
Ah true, someone in the Processing Org still needs to approve the personal access token from processing-bot |
Sorry, something went wrong.
|
@Stefterv ah thank you for pointing that out! just approved |
Sorry, something went wrong.
|
Aaand the secret is not available as long as it is a PR... 🫠 |
Sorry, something went wrong.
|
I think so, it works on my fork and we can always disable it again later |
Sorry, something went wrong.
75926c8
into
processing:main
Feb 5, 2026
|
Merged! 🤞🏽 :) |
Sorry, something went wrong.
Update the build workflow to handle pull request runs: make the main artifact upload conditional (skip for pull_request), add a separate upload step for PR artifacts with longer retention, and post a sticky PR comment containing a download link. Also adjust workflow permissions to allow pull-request write access and include updated artifact paths.
See bot output here Stefterv#11 (comment)