{{ message }}
Resource Leaks in processing/app/Util.java#1436
Merged
catilac merged 4 commits intoFeb 17, 2026
Merged
Conversation
Contributor
Sorry, something went wrong.
to put the test in the appropriate directory, id have to java files to grade build configs, because it currently only checks for kotlin tests.
create a temp zip file > create a destination that is a file not a directory (guaranteed exception) -> unzip throws ioexception because it expects a directory not a file -> catch it -> check if the zip file is still open -> if true == leak.
tychedelia
reviewed
Feb 16, 2026
tychedelia
left a comment
tychedelia
left a comment
Member
There was a problem hiding this comment.
Looks good! We should just either gate or remove the test.
Sorry, something went wrong.
Ive also removed the test since its OS specific, and new code is supposed to be in kotlin.
Collaborator
|
Thanks y'all! Running the tests. I'll go ahead an approve it |
Sorry, something went wrong.
catilac
approved these changes
Feb 17, 2026
Hide details
View details
catilac
merged commit
catilac
merged commit 05290b8
into
processing:main
Feb 17, 2026
6 checks passed
Collaborator
|
@all-contributors please add @SalmaneKhalili for bug-finding, and bug-fixing |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This PR add a simple implementation of what was suggested in #1432, at the moment it was only applied to unzip, i should be able to do the same for the rest of the methods mentioned in the issue, but id like to have feedback on the current way im going about it.