{{ message }}
Updated readInt method so streams are closed on failure or success#1476
Open
srnkan wants to merge 2 commits into
Open
Updated readInt method so streams are closed on failure or success#1476srnkan wants to merge 2 commits into
srnkan wants to merge 2 commits into
Conversation
Sorry, something went wrong.
Collaborator
|
@srnkan sorry for the confusion in closing the issue without comment. i'll leave a review soon. i can't add ebaron96 as a reviewer until they have contributed code. but they are welcome to review. |
Sorry, something went wrong.
catilac
requested changes
Mar 11, 2026
catilac
left a comment
catilac
left a comment
Collaborator
There was a problem hiding this comment.
This is a great start! I noticed there aren't any tests in the UpdateCheckTest class.
It could use some!
Sorry, something went wrong.
srnkan
force-pushed
the
ClosingStreamsIssue
branch
from
47a8802 to
b9b794e
Compare
March 23, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
✅ Title: clear and descriptive
✅ Resolves: Resolves #1416
✅ Changes: I adapted the preexisting readInt method to include a try-with-resources, which closes all "closeables" regardless if the code errors or runs smoothly. This stops memory leakage by always closing necessary streams.
✅ Tests: Tests pass the "./gradlew test" and I did not add any additional tests
✅ Checklist: Tests pass the "./gradlew test" tests and branch is up-to-date