gh-100062: Remove error code tables from _ssl and err_names_to_codes#100063
gh-100062: Remove error code tables from _ssl and err_names_to_codes#100063zooba merged 2 commits into
Conversation
Sorry, something went wrong.
…codes Prior to python#25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list. After that PR, this is no longer used. Moreover, the err_names_to_codes map isn't used at all. Clean those up. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sorry, something went wrong.
|
@tiran This PR look reasonable? Anything missing on my end? |
Sorry, something went wrong.
|
Adding the |
Sorry, something went wrong.
arhadthedev
added
skip news
extension-modules
C modules in the Modules dir
topic-SSL
labels
Apr 1, 2023
|
This looks good to me, but I'm going to wait for a bit before merging in case one of the other maintainers know of a reason these were exposed. |
Sorry, something went wrong.
|
My (possibly wrong) guess is that were exposed for the older version of the make_ssl_data.py script. (See PR description.) |
Sorry, something went wrong.
zooba
left a comment
zooba
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Let's merge this before the next alpha so there's more time for someone to shout if we shouldn't have dropped it. |
Sorry, something went wrong.
…codes (pythonGH-100063) Prior to python#25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list. After that PR, this is no longer used. Moreover, the err_names_to_codes map isn't used at all. Clean those up. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)
…codes (pythonGH-100063) Prior to python#25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list. After that PR, this is no longer used. Moreover, the err_names_to_codes map isn't used at all. Clean those up. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)
Prior to #25300, the make_ssl_data.py script used various tables, exposed in _ssl, to update the error list.
After that PR, this is no longer used. Moreover, the err_names_to_codes map isn't used at all. Clean those up. This gets them out of the way if, in the future, OpenSSL provides an API to do what the code here is doing directly. (openssl/openssl#19848)