{{ message }}
GH-98831: Remove super-instruction definitions, use macro instructions instead#100124
Closed
gvanrossum wants to merge 2 commits into
Closed
GH-98831: Remove super-instruction definitions, use macro instructions instead#100124gvanrossum wants to merge 2 commits into
gvanrossum wants to merge 2 commits into
Conversation
Member
Sorry, something went wrong.
Member
|
Not gonna lie, the PR title scared me. |
Sorry, something went wrong.
gvanrossum
force-pushed
the
remove-supers
branch
from
6706827 to
eadca51
Compare
December 9, 2022 00:01
Member
Author
|
Clearly I should use more provocative PR titles more often. :-) |
Sorry, something went wrong.
brandtbucher
reviewed
Dec 9, 2022
gvanrossum
commented
Dec 9, 2022
gvanrossum
left a comment
gvanrossum
left a comment
Member
Author
There was a problem hiding this comment.
I'm feeling a lot of hesitation about this PR. Maybe we should just leave things as they were and focus on other work (e.g. finish converting more instructions to the explicit stack/cache effects form, and adding arrays).
Sorry, something went wrong.
Member
Author
|
Off-line we decided not to do this. Super-instructions may eventually disappear (when we have a register VM). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Replace all super-instructions with macros, using a special JOIN op to extract the next oparg. JOIN has a cache effect of one word that is equivalent to bumping next_instr.
Rip out all code for parsing and generating super-instructions.