still need to fix the fstring test -- might need some help from @ambv given #1800 this should be ready for review now!

(I've rebased to regen importlib to resolve the conflict)

(I've rebased to regen importlib to resolve the conflict)

Diff and tests looks good to me.
But I don't understand about parser and tokenizer well.

@ericvsmith would you review this? You seems reviewed #1800.

I'll take a look, but it might take me a while to get to it. Unfortunately I have a project that's due at the end of the year that's taking up all of my time. So while I'll try, you might not want to wait for me.

I'm working on a fix to bpo-34364 that will completely back out the changes implemented in #1800. I'm not sure if that will interact with this change, though.

maybe @ambv can take a look too? (authored #1800)

(I've rebased to regen importlib to resolve the conflict)

Commands for me for next time since I expect this to not be the last:

git fetch --all
git checkout [bpo-16806](https://bugs.python.org/issue16806)
git reset --hard asottile/[bpo-16806](https://bugs.python.org/issue16806)
git pull --rebase origin master
git checkout origin/master -- Python/importlib*  # when rebase fails
make regen-importlib
git add Python
git rebase --continue
git push asottile HEAD -f

urgh, the bot edited my comment and broke my code block :(

(I've rebased to regen importlib to resolve the conflict)

Please take a look, this is tedious -- I'd like to be done with this branch!

(I've rebased to regen importlib to resolve the conflict)

Please take a look, this is tedious -- I'd like to be done with this branch!

@methane @ericvsmith @ambv <3

happy new year! friendly ping :)

Is there a reason why this wasn't backported to 3.6 and 3.7, just like #1800/bpo-30465?
Trying to get PyPy to pass related tests, but there seems to be a discrepancy in behavior between 3.6/3.7 and 3.8.

changes to the ast generally shouldn't be backported because they break linters / code formatters which make assumptions about how minor versions of python work

in this particular case, this was discussed on bpo if you want more information

@asottile Sorry, should've read that better! Thanks!