◐ Shell
reader mode source ↗
Skip to content

gh-100176: Mac/build-installer: Remove redundant compat code for Python 3.5 and older#100297

Closed
hugovk wants to merge 1 commit into
python:mainfrom
hugovk:100176-mac-build-installer
Closed

gh-100176: Mac/build-installer: Remove redundant compat code for Python 3.5 and older#100297
hugovk wants to merge 1 commit into
python:mainfrom
hugovk:100176-mac-build-installer

Conversation

@hugovk

@hugovk hugovk commented Dec 16, 2022

Copy link
Copy Markdown
Member

Python 3.5 has been EOL since 2020-09-13 and 2.7 since 2020-01-01, so we can remove these old compatibility checks.

https://devguide.python.org/versions/

Python 3.5 has been EOL since 2020-09-13 and 2.7 since 2020-01-01, so we
can remove these old compatibility checks.
@hugovk hugovk requested a review from a team as a code owner December 16, 2022 16:06
@hugovk hugovk changed the title gh-100176: Remove redundant compat code for Python 3.5 and older Dec 16, 2022
@ned-deily

Copy link
Copy Markdown
Member

Thanks for your efforts but I would prefer to leave build-installer.py untouched for now. I will be making much more substantial changes to it later in the current release cycle and for now it's easier to keep it in sync with other active versions.

@hugovk

hugovk commented Dec 16, 2022

Copy link
Copy Markdown
Member Author

Sure! Let's close this.

@hugovk hugovk closed this Dec 16, 2022
@hugovk hugovk deleted the 100176-mac-build-installer branch December 16, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants