◐ Shell
reader mode source ↗
Skip to content

bpo-35039: remove unused clock() objects add pep8 corrections#10044

Closed
eamanu wants to merge 2 commits into
python:masterfrom
eamanu:pr_10033
Closed

bpo-35039: remove unused clock() objects add pep8 corrections#10044
eamanu wants to merge 2 commits into
python:masterfrom
eamanu:pr_10033

Conversation

@eamanu

@eamanu eamanu commented Oct 22, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bpo-35039: remove unused clock() objects and add pep8 correction

This is based on #10033 But add some pep8 corrections

https://bugs.python.org/issue35039

@ned-deily

ned-deily commented Oct 22, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@eamanu Thanks for your contribution. If you submit a PR and then need to change something before it is merged, just push new commits to the existing PR, don't open a new one, please. That just creates confusion. If this #10044 is supposed to supersede #10033, please close it. Thanks!

@ned-deily

ned-deily commented Oct 22, 2018

Copy link
Copy Markdown
Member

Oh, sorry, I missed that #10033 was created by @srinivasreddy. Perhaps the two of you can settle on one PR.

@ned-deily ned-deily mentioned this pull request Oct 22, 2018
Merged
@srinivasreddy

srinivasreddy commented Oct 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

@eamanu Could you please raise an another ticket for pep8 changes and use it?.

@eamanu

eamanu commented Oct 23, 2018

Copy link
Copy Markdown
Contributor Author

@ned-deily ohh sorry for the confusion! Now, I will work with @srinivasreddy

@eamanu

eamanu commented Oct 23, 2018

Copy link
Copy Markdown
Contributor Author

@srinivasreddy Ok, so I will Close this PR and I will create a new PR for pep8 solution. Right?

@srinivasreddy

srinivasreddy commented Oct 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Yes, please. You do not need to close this PR. You can remove my commit and do the rest.

@eamanu

eamanu commented Oct 23, 2018

Copy link
Copy Markdown
Contributor Author

Ok! Thanks!

@eamanu eamanu closed this Oct 23, 2018
@eamanu eamanu deleted the pr_10033 branch October 23, 2018 13:47
@eamanu eamanu mentioned this pull request Oct 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eamanu @ned-deily @srinivasreddy @the-knights-who-say-ni @bedevere-bot