◐ Shell
reader mode source ↗
Skip to content

bpo-31553: add --json-lines option to json.tool#10051

Merged
serhiy-storchaka merged 4 commits into
python:masterfrom
hongweipeng:jsonlines-for-json.tool
Nov 7, 2018
Merged

bpo-31553: add --json-lines option to json.tool#10051
serhiy-storchaka merged 4 commits into
python:masterfrom
hongweipeng:jsonlines-for-json.tool

Conversation

@hongweipeng

@hongweipeng hongweipeng commented Oct 23, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

vstinner
vstinner reviewed Oct 24, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The change LGTM, but I'm not 100% sure about the usefulness of the feature :-) See discussion at https://bugs.python.org/issue31553

serhiy-storchaka
serhiy-storchaka requested changes Oct 25, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Needed the documentation and an entry in What's New.

@bedevere-bot

bedevere-bot commented Oct 25, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hongweipeng

hongweipeng commented Oct 26, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Oct 26, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@hongweipeng hongweipeng changed the title bpo-31553: add jsonlines option to json.tool Oct 26, 2018
matrixise
matrixise reviewed Oct 26, 2018
View reviewed changes

@matrixise matrixise left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

You can add your full name if you prefer.

@hongweipeng

hongweipeng commented Oct 26, 2018

Copy link
Copy Markdown
Contributor Author

@matrixise It's my full name :)

@hongweipeng

hongweipeng commented Nov 5, 2018

Copy link
Copy Markdown
Contributor Author

ping

@serhiy-storchaka serhiy-storchaka merged commit f194479 into python:master Nov 7, 2018
@bedevere-bot

bedevere-bot commented Nov 7, 2018

Copy link
Copy Markdown

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!

@serhiy-storchaka

serhiy-storchaka commented Nov 7, 2018

Copy link
Copy Markdown
Member

Damn it! I have pressed Enter by mistake while edited commit message.

Thank you for your contribution @hongweipeng!

@hongweipeng

hongweipeng commented Nov 7, 2018

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka Oh!It is a beautiful mistake for me. Will you revoke this merger?

@serhiy-storchaka

serhiy-storchaka commented Nov 7, 2018

Copy link
Copy Markdown
Member

It can't be revoked without making larger harm.

@dhimmel dhimmel mentioned this pull request Dec 6, 2019
Merged
@hongweipeng hongweipeng deleted the jsonlines-for-json.tool branch March 16, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise

@vstinner vstinner vstinner left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hongweipeng @bedevere-bot @serhiy-storchaka @matrixise @vstinner @the-knights-who-say-ni