◐ Shell
reader mode source ↗
Skip to content

gh-87688: Amend SSLContext.hostname_checks_common_name docs#100517

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
ramikg:patch-1
Feb 17, 2024
Merged

gh-87688: Amend SSLContext.hostname_checks_common_name docs#100517
serhiy-storchaka merged 4 commits into
python:mainfrom
ramikg:patch-1

Conversation

@ramikg

@ramikg ramikg commented Dec 24, 2022 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

According to #87688, the bug affecting SSLContext.hostname_checks_common_name was fixed in openssl/openssl@dfccfde, which was introduced in OpenSSL 1.1.1l (and not 1.1.1k as in the docs).

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 24, 2022
@ramikg ramikg closed this Jan 17, 2023
@ramikg ramikg deleted the patch-1 branch January 17, 2023 08:41
@ramikg ramikg restored the patch-1 branch January 17, 2023 08:42
@ramikg ramikg reopened this Jan 17, 2023
@arhadthedev

arhadthedev commented Feb 5, 2023

Copy link
Copy Markdown
Member

@alex (as the ssl expert), would you mind to review and possibly merge this PR? It improves a factual error in the OpenSSL version mentioned in versionchanged.

@alex alex requested a review from tiran February 5, 2023 13:08
AA-Turner
AA-Turner approved these changes Jan 12, 2024
View reviewed changes

@AA-Turner AA-Turner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The said commit does seem to appear in 1.1.1l: https://github.com/openssl/openssl/commits/OpenSSL_1_1_1l/?author=tiran, but not 1.1.1k: https://github.com/openssl/openssl/commits/OpenSSL_1_1_1k/?author=tiran

A

@erlend-aasland erlend-aasland changed the title Fix typo in ssl.rst Jan 16, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 16, 2024
Closed
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) February 17, 2024 10:14
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 17, 2024
@serhiy-storchaka serhiy-storchaka merged commit debb138 into python:main Feb 17, 2024
@miss-islington-app

miss-islington-app Bot commented Feb 17, 2024

Copy link
Copy Markdown

Thanks @ramikg for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2024
@ramikg @miss-islington
pythongh-87688: Amend SSLContext.hostname_checks_common_name docs (py… …
29e2d99 
…thonGH-100517)

(cherry picked from commit debb138)

Co-authored-by: Rami <72725910+ramikg@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Feb 17, 2024

Copy link
Copy Markdown

GH-115594 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 17, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2024
@ramikg @miss-islington
pythongh-87688: Amend SSLContext.hostname_checks_common_name docs (py… …
113b7a9 
…thonGH-100517)

(cherry picked from commit debb138)

Co-authored-by: Rami <72725910+ramikg@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Feb 17, 2024

Copy link
Copy Markdown

GH-115595 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Feb 17, 2024
@ramikg ramikg deleted the patch-1 branch February 17, 2024 12:56
serhiy-storchaka pushed a commit that referenced this pull request Feb 17, 2024
@miss-islington @ramikg
[3.11] gh-87688: Amend SSLContext.hostname_checks_common_name docs (G… …
bc11905 
…H-100517) (GH-115595)

(cherry picked from commit debb138)

Co-authored-by: Rami <72725910+ramikg@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Feb 17, 2024
@miss-islington @ramikg
[3.12] gh-87688: Amend SSLContext.hostname_checks_common_name docs (G… …
068e219 
…H-100517) (GH-115594)

(cherry picked from commit debb138)

Co-authored-by: Rami <72725910+ramikg@users.noreply.github.com>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@ramikg @woodruffw
pythongh-87688: Amend SSLContext.hostname_checks_common_name docs (py… …
0ef07aa 
…thonGH-100517)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@ramikg @diegorusso
pythongh-87688: Amend SSLContext.hostname_checks_common_name docs (py… …
a2f8730 
…thonGH-100517)
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@ramikg @LukasWoodtli
pythongh-87688: Amend SSLContext.hostname_checks_common_name docs (py… …
f810c61 
…thonGH-100517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-SSL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ramikg @arhadthedev @serhiy-storchaka @AA-Turner @erlend-aasland @bedevere-bot @AlexWaygood