{{ message }}
gh-100540: Remove obsolete '--with-system-ffi' configure option#100544
Merged
zware merged 1 commit intoDec 28, 2022
Merged
Conversation
Member
Sorry, something went wrong.
It has had no effect on non-macOS platforms for a long time, and has had the non-obvious effect of invoking `pkg_config` and not setting `-DUSING_APPLE_OS_LIBFFI` on macOS since pythonGH-22855.
zware
added
3.12
only security fixes
OS-mac
build
The build process and cross-build
topic-ctypes
extension-modules
C modules in the Modules dir
labels
Dec 26, 2022
zware
added
the
🔨 test-with-buildbots
Test PR w/ buildbots; report in status section
label
Dec 26, 2022
bedevere-bot
removed
the
🔨 test-with-buildbots
Test PR w/ buildbots; report in status section
label
Dec 26, 2022
erlend-aasland
approved these changes
Dec 28, 2022
erlend-aasland
left a comment
erlend-aasland
left a comment
Contributor
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
Gusse500
added a commit
to Gusse500/LFS-Norsk
that referenced
this pull request
Nov 1, 2023
Dette alternativet er fjernet av oppstrøms i 3.12. Link: python/cpython#100544
Poltern
added a commit
to Poltern/lfs-ru
that referenced
this pull request
Nov 1, 2023
This option is removed by upstream in 3.12. Link: python/cpython#100544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
It has had no effect on non-macOS platforms for a long time, and has had
the non-obvious effect of invoking
pkg_configand not setting-DUSING_APPLE_OS_LIBFFIon macOS since GH-22855._ctypes/libffibuild, particularly on macOS #100540