{{ message }}
gh-94912: Adjusted check for non-standard coroutine function marker.#100935
Merged
gvanrossum merged 1 commit intoJan 11, 2023
Merged
gh-94912: Adjusted check for non-standard coroutine function marker.#100935gvanrossum merged 1 commit into
gvanrossum merged 1 commit into
Conversation
Contributor
Sorry, something went wrong.
…rker. The initial implementation did not correctly identify explicitly marked class instances. Follow up to 532aa4e
Contributor
Author
|
I think this could skip news? 🤔 |
Sorry, something went wrong.
Contributor
|
Confirming this resolves the issues for Django ✔️ Thanks! |
Sorry, something went wrong.
sobolevn
reviewed
Jan 11, 2023
gvanrossum
approved these changes
Jan 11, 2023
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
LGTM. I will merge this.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The initial implementation did not correctly identify explicitly marked class instances.
Follow up to 532aa4e from #99247
(Bug in Python 3.12.0a4)
Integrating Python 3.12.0a4 with the Django test suite we see that the
_has_coroutine_mark()is not allowing the key case of a class being marked as an asynchronous callable. (This is my fault: in the discussion with @gvanrossum on #99247 over whether we'd cover the marked andasync def__call__cases automatically, I forgot to add the explicit test for the marked instances.)I note the
isfunction(f) or _signature_is_functionlike(f)restriction is untested, and not, I think, necessary. (If folks appliedmarkcoroutinefunction, I think we have to assume that they know what they're up to.)asyncio.iscoroutinefunctiona deprecated alias ofinspect.iscoroutinefunctionand removeasyncio.coroutines._is_coroutine#94912