{{ message }}
GH-98831: Identify instructions that don't use oparg#100957
Merged
gvanrossum merged 4 commits intoJan 14, 2023
Merged
Conversation
Member
Sorry, something went wrong.
For these the instr_format field uses I_ instead of IB. Register instructions use I_, IB, IBB_, IBBB, etc.
brandtbucher
requested changes
Jan 12, 2023
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Looks mostly good, just a bit confused by the register formats you're generating.
Sorry, something went wrong.
|
When you're done making the requested changes, leave the comment: |
Sorry, something went wrong.
Member
Author
|
I have made the requested changes; please review again |
Sorry, something went wrong.
|
Thanks for making the requested changes! @brandtbucher: please review the changes made to this pull request. |
Sorry, something went wrong.
brandtbucher
approved these changes
Jan 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
For these the instr_format field uses I_ instead of IB.
Register instructions use I_, IB, IBB_, IBBB, etc.