◐ Shell
reader mode source ↗
Skip to content

[3.11] Clarify re docs for byte pattern group names (GH-99308)#101001

Merged
hauntsaninja merged 1 commit into
python:3.11from
GreatFruitOmsk:fix-re-docstring-3.11
Mar 4, 2023
Merged

[3.11] Clarify re docs for byte pattern group names (GH-99308)#101001
hauntsaninja merged 1 commit into
python:3.11from
GreatFruitOmsk:fix-re-docstring-3.11

Conversation

@Kentzo

@Kentzo Kentzo commented Jan 12, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot mentioned this pull request Jan 12, 2023
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 12, 2023
@slateny

slateny commented Jan 14, 2023

Copy link
Copy Markdown
Contributor

Per comment I don't believe there should be a backport for this.

@Kentzo

Kentzo commented Jan 14, 2023

Copy link
Copy Markdown
Contributor Author

#99308 (comment) says otherwise

CAM-Gerlach
CAM-Gerlach reviewed Jan 14, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks @Kentzo . One set of suggestions, otherwise LGTM

hauntsaninja
hauntsaninja approved these changes Jan 17, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for backporting this!

Looks like it's common enough for past versions of docs to contain "removed" for future versions of Python, so would you mind applying CAM's suggestions?

Edit: Since this has been lying around, I think this is fine to merge as is without the more specific directives; 3.12 isn't finalised and this seems like a short time between deprecation and removal.

@hauntsaninja hauntsaninja merged commit cda1d52 into python:3.11 Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kentzo @slateny @hauntsaninja @CAM-Gerlach @bedevere-bot