You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
Dismiss alert
{{ message }}
gh-94518: Rename group* to extra_group* to avoid confusion#101054
Todo: replace groups_size/groups parameter names with extra_group_size/extra_groups across the whole file to avoid confusion of passers-by. It's necessary to mitigate a misleading name of setgroups that supposes replacement of not supplimentary group affinities, but all ones. The mislead results in seeing the omission of setgroups call for groups_size == 0 as a bug (like we should reset the inherited affinities but do nothing instead).
I'll do it in a separate PR because both this PR and gh-94519 are already big enough to clobber them with extra details.
Edit: this PR also unifies terminology by further renaming groups_list parameter and num_groups variable into extra_groups_packed and extra_group_size.
Converted to draft again to rerun tests because spurious PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'D:\\a\\cpython\\cpython\\build\\test_python_6372�\\test_python_worker_6400�'struck again on Windows x64.
Removed spuriously added technical _packed suffix from a Python signature of fork_exec. It's relevant inside C code only (to distinguish PyObject and gid_t * variants of extra_groups).
However, a new extra_groups argument name retains because fork_exec arguments are positional-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This PR addresses #94687 (comment):
Edit: this PR also unifies terminology by further renaming
groups_listparameter andnum_groupsvariable intoextra_groups_packedandextra_group_size.cc @gpshead
_posixsubprocess.fork_execto Argument Clinic #94518