gh-101152: Implement PEP 699#101193
Conversation
|
Sorry, something went wrong.
added the news and infact it is a replica of his solution |
Sorry, something went wrong.
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Just some feedback for your future contributions:
- You can close conversations. Click on the "resolve conversation" button once you feel that you resolved the comment.
- reStructuredText markup is a little tricky! So you can refer to the devguide for that https://devguide.python.org/documentation/markup/
- I'll try to summarise what I look for in the Whats New deprecation. First you want to know exactly what is being affected (in this case the field of a certain struct being deprecated). Secondly, you want to know, without ambiguity, how we will notify users of this deprecation. In this case it's a compiler warning. Lastly, if there's a planned removal version for the deprecated thing, it should be mentioned too.
Thank you.
Sorry, something went wrong.
Co-authored-by: Ken Jin <kenjin@python.org>
…8pL.rst Co-authored-by: Ken Jin <kenjin@python.org>
The feedback was very helpful, will surely keep the points in mind. Thanks |
Sorry, something went wrong.
Co-authored-by: Ken Jin <kenjin@python.org>
kumaraditya303
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
Can you rebase with main and fix the conflicts in 3.12 whats new please? Seems like someone wrote an entry at the current spot. |
Sorry, something went wrong.
yes sure |
Sorry, something went wrong.
gh-101152: Added the PEP 699 Implementation