◐ Shell
reader mode source ↗
Skip to content

gh-98831: rewrite CHECK_EG_MATCH opcode in the instruction definition DSL#101269

Merged
iritkatriel merged 3 commits into
python:mainfrom
iritkatriel:CHECK_EG_MATCH
Jan 24, 2023
Merged

gh-98831: rewrite CHECK_EG_MATCH opcode in the instruction definition DSL#101269
iritkatriel merged 3 commits into
python:mainfrom
iritkatriel:CHECK_EG_MATCH

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jan 23, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The change in exception_group_match is needed because previously in the case of match == None the opcode didn't look at rest, but now it pushes to the stack (even though it's already there) to keep the code uniform with the match != None case.

@bedevere-bot bedevere-bot mentioned this pull request Jan 23, 2023
Closed
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jan 23, 2023
gvanrossum
gvanrossum approved these changes Jan 23, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks like this one wasn't trivial. Thanks!

@iritkatriel
Revert "Add news" …
93d98ab 
This reverts commit 48d0fcb.
@iritkatriel

iritkatriel commented Jan 23, 2023

Copy link
Copy Markdown
Member Author

I'll kick off the buildbots in case refcount.

@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2023
@bedevere-bot

bedevere-bot commented Jan 23, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 93d98ab 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2023
@gvanrossum

gvanrossum commented Jan 24, 2023

Copy link
Copy Markdown
Member

PPC64 Fedora PR is failing with "No space left on device", so I wouldn't worry about that one. :)

@iritkatriel iritkatriel merged commit 8c183cd into python:main Jan 24, 2023
@iritkatriel iritkatriel deleted the CHECK_EG_MATCH branch April 3, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel @bedevere-bot @gvanrossum