◐ Shell
reader mode source ↗
Skip to content

GH-101578: Normalize the current exception#101607

Merged
markshannon merged 13 commits into
python:mainfrom
faster-cpython:normalize-current-exception
Feb 8, 2023
Merged

GH-101578: Normalize the current exception#101607
markshannon merged 13 commits into
python:mainfrom
faster-cpython:normalize-current-exception

Conversation

@markshannon

@markshannon markshannon commented Feb 6, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This is a necessary step for implementing PEP 669, as instrumentation needs exceptions to be normalized.

Also fixes #101578.

@bedevere-bot bedevere-bot mentioned this pull request Feb 6, 2023
Closed
@markshannon markshannon requested a review from a team as a code owner February 7, 2023 12:43
@markshannon markshannon closed this Feb 7, 2023
@markshannon markshannon reopened this Feb 7, 2023
iritkatriel
iritkatriel approved these changes Feb 7, 2023
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. I'd run tests with the buildbots before merging though.

@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@bedevere-bot

bedevere-bot commented Feb 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 566f6e1 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@bedevere-bot

bedevere-bot commented Feb 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 99f0880 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 7, 2023
@markshannon

markshannon commented Feb 8, 2023

Copy link
Copy Markdown
Member Author

The buildbot/PPC64LE RHEL8 Refleaks PR failure seems unrelated (the other refleak buildbots all pass) and that buildbot seems a bit flaky.

@markshannon markshannon merged commit feec49c into python:main Feb 8, 2023
@markshannon markshannon deleted the normalize-current-exception branch February 8, 2023 09:31
carljm added a commit to carljm/cpython that referenced this pull request Feb 9, 2023
@carljm
Merge branch 'main' into inlinecomp2 …
be3becc 
* main: (82 commits)
  pythongh-101670: typo fix in PyImport_ExtendInittab() (python#101723)
  pythonGH-99293: Document that `Py_TPFLAGS_VALID_VERSION_TAG` shouldn't be used. (#pythonGH-101736)
  no-issue: Add Dong-hee Na as the cjkcodecs codeowner (pythongh-101731)
  pythongh-101678: Merge math_1_to_whatever() and math_1() (python#101730)
  pythongh-101678: refactor the math module to use special functions from c11 (pythonGH-101679)
  pythongh-85984: Remove legacy Lib/pty.py code. (python#92365)
  pythongh-98831: Use opcode metadata for stack_effect() (python#101704)
  pythongh-101283: Version was just released, so should be changed in 3.11.3 (pythonGH-101719)
  pythongh-101283: Fix use of unbound variable (pythonGH-101712)
  pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286)
  pythongh-101277: Port more itertools static types to heap types (python#101304)
  pythongh-98831: Modernize CALL and family (python#101508)
  pythonGH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (python#101697)
  pythongh-100221: Fix creating dirs in `make sharedinstall` (pythonGH-100329)
  pythongh-101670: typo fix in PyImport_AppendInittab() (pythonGH-101672)
  pythongh-101196: Make isdir/isfile/exists faster on Windows (pythonGH-101324)
  pythongh-101614: Don't treat python3_d.dll as a Python DLL when checking extension modules for incompatibility (pythonGH-101615)
  pythongh-100933: Improve `check_element` helper in `test_xml_etree` (python#100934)
  pythonGH-101578: Normalize the current exception (pythonGH-101607)
  pythongh-47937: Note that Popen attributes are read-only (python#93070)
  ...
@erlend-aasland erlend-aasland mentioned this pull request Feb 17, 2023
Merged
@CAM-Gerlach CAM-Gerlach mentioned this pull request Feb 19, 2023
Merged
@tacaswell tacaswell mentioned this pull request Mar 1, 2023
Closed
@ned-deily ned-deily mentioned this pull request Mar 7, 2023
Closed
@iritkatriel iritkatriel mentioned this pull request Mar 13, 2023
Closed
@brianschubert brianschubert mentioned this pull request May 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@methane methane methane is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PyErr_SetObject() behavior is strange and not as documented.

3 participants

@markshannon @bedevere-bot @iritkatriel