{{ message }}
gh-98831: Modernize the FOR_ITER family of instructions#101626
Merged
gvanrossum merged 7 commits intoFeb 7, 2023
Merged
Conversation
Member
Sorry, something went wrong.
gvanrossum
requested review from
Fidget-Spinner,
brandtbucher and
iritkatriel
February 7, 2023 00:26
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
Member
There was a problem hiding this comment.
Code looks good. Just one question
Sorry, something went wrong.
iritkatriel
reviewed
Feb 7, 2023
iritkatriel
approved these changes
Feb 7, 2023
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This is somewhat tricky because most of the family members (with the exception of FOR_ITER_GEN) are actually super-instructions that jump over the END_FOR instruction that is the target of the jump (which pops two stack items). In addition, FOR_ITER_RANGE also jumps over the STORE_FAST that follows it when the range is not exhausted.
The cache and stack effects documented in the DSL don't acknowledge the existence of these optimizations. (This will bite us when we try to incorporate these instructions in a level 2 interpreter, we'll have to deal with it then.)