{{ message }}
gh-98239: Document that inspect.getsource() can raise TypeError#101689
Merged
AlexWaygood merged 2 commits intoMar 23, 2023
Merged
gh-98239: Document that inspect.getsource() can raise TypeError#101689AlexWaygood merged 2 commits into
inspect.getsource() can raise TypeError#101689AlexWaygood merged 2 commits into
Conversation
Member
Sorry, something went wrong.
Member
Author
|
@AlexWaygood this is quite a simple change, but it is stuck. Can you please take a look? |
Sorry, something went wrong.
AlexWaygood
reviewed
Mar 23, 2023
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
LGTM! Just two small suggestions to minimise the diff and keep the additions consistent with the immediate surrounding text:
Sorry, something went wrong.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Mar 23, 2023
AlexWaygood
added
needs backport to 3.10
only security fixes
needs backport to 3.11
only security fixes
labels
Mar 23, 2023
Contributor
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 23, 2023
…ror` (pythonGH-101689) (cherry picked from commit b613208) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 23, 2023
…ror` (pythonGH-101689) (cherry picked from commit b613208) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Now all
inspect.getsourcefile,inspect.getsourcelines, andinspect.getsourcemention theTypeErrorcase.cc @ericvsmith