◐ Shell
reader mode source ↗
Skip to content

[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286)#101711

Merged
miss-islington merged 2 commits into
python:3.11from
miss-islington:backport-23751ed-3.11
Feb 8, 2023
Merged

[3.11] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286)#101711
miss-islington merged 2 commits into
python:3.11from
miss-islington:backport-23751ed-3.11

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 8, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin oleg@arhadthedev.net

@arhadthedev @miss-islington
pythongh-101283: Improved fallback logic for subprocess with shell=Tr… …
644134d 
…ue on Windows (pythonGH-101286)

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
This was referenced Feb 8, 2023
Closed
Merged
@bedevere-bot

bedevere-bot commented Feb 8, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington miss-islington merged commit 51b079a into python:3.11 Feb 8, 2023
@miss-islington miss-islington deleted the backport-23751ed-3.11 branch February 8, 2023 23:44
@zooba

zooba commented Feb 8, 2023

Copy link
Copy Markdown
Member

Whoops 😆 Forgot that hitting approve would merge it immediately

#101719 will backport to it at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead requested changes

@zooba zooba zooba approved these changes

Assignees

No one assigned

Labels

type-security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @bedevere-bot @zooba @gpshead @arhadthedev