◐ Shell
reader mode source ↗
Skip to content

gh-101860: Expose __name__ on property#101876

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
eltoder:feature/property-name
Feb 20, 2024
Merged

gh-101860: Expose __name__ on property#101876
serhiy-storchaka merged 4 commits into
python:mainfrom
eltoder:feature/property-name

Conversation

@eltoder

@eltoder eltoder commented Feb 13, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Useful for introspection and consistent with functions and other descriptors.

@bedevere-bot bedevere-bot mentioned this pull request Feb 13, 2023
Closed
@bedevere-bot

bedevere-bot commented Feb 13, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@eltoder eltoder force-pushed the feature/property-name branch 3 times, most recently from 05db108 to 9c956c7 Compare February 13, 2023 18:00
@serhiy-storchaka

serhiy-storchaka commented Feb 17, 2024

Copy link
Copy Markdown
Member

@eltoder, there are a lot of conflicts now. Could you please update the branch?

@serhiy-storchaka serhiy-storchaka self-requested a review February 17, 2024 08:17
@eltoder
pythongh-101860: Expose __name__ on property …
8ec1251 
Useful for introspection and consistent with functions and other
descriptors.
@eltoder eltoder force-pushed the feature/property-name branch from 9c956c7 to 8ec1251 Compare February 17, 2024 15:59
@eltoder

eltoder commented Feb 17, 2024

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka Done

@serhiy-storchaka

serhiy-storchaka commented Feb 17, 2024

Copy link
Copy Markdown
Member

Thank you. I knew I could count on you.

@eltoder

eltoder commented Feb 20, 2024

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka I made __name__ default to fget.__name__ when possible. What do you think?

@eltoder
Fallback to fget.__name__ if name is not set …
c20e9a7 
Raise AttributeError if no fget or it doesn't have `__name__`.
@eltoder eltoder force-pushed the feature/property-name branch from 732337d to c20e9a7 Compare February 20, 2024 04:40
serhiy-storchaka
serhiy-storchaka approved these changes Feb 20, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. And I like to to review more of your PRs.

@serhiy-storchaka serhiy-storchaka merged commit c0b0c2f into python:main Feb 20, 2024
@eltoder eltoder deleted the feature/property-name branch February 20, 2024 15:33
@eltoder

eltoder commented Feb 20, 2024

Copy link
Copy Markdown
Contributor Author

Thank you!

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@eltoder @woodruffw
pythongh-101860: Expose __name__ on property (pythonGH-101876) …
f7dedb5 
Useful for introspection and consistent with functions and other
descriptors.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@eltoder @diegorusso
pythongh-101860: Expose __name__ on property (pythonGH-101876) …
794df41 
Useful for introspection and consistent with functions and other
descriptors.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@eltoder @LukasWoodtli
pythongh-101860: Expose __name__ on property (pythonGH-101876) …
b7abd7a 
Useful for introspection and consistent with functions and other
descriptors.
dangotbanned added a commit to narwhals-dev/narwhals that referenced this pull request Apr 23, 2025
@dangotbanned
fix: pre-3.13 compat? …
86dda9b 
Following where `__name__` used to be sourced from
- python/cpython#101876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eltoder @bedevere-bot @serhiy-storchaka