gh-101819: Remove _PyWindowsConsoleIO_Type from the Windows DLL#101904
gh-101819: Remove _PyWindowsConsoleIO_Type from the Windows DLL#101904miss-islington merged 4 commits into
Conversation
|
Does this work for you, @zooba? Re. #101819 (comment) |
Sorry, something went wrong.
|
Can you remove the I'd kinda like to see a few more |
Sorry, something went wrong.
The one in |
Sorry, something went wrong.
|
I was thinking the definition in Provided we're not changing any supported public API, it's fine. |
Sorry, something went wrong.
AFAICS, |
Sorry, something went wrong.
|
Perhaps we should wait for #101919 to land, before merging this 😄 cc. @ericsnowcurrently |
Sorry, something went wrong.
|
Don't worry about waiting for that PR to merge. I don't think it conflicts. Regardless, I don't mind fixing my branch if needed. |
Sorry, something went wrong.
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
Status check is done, and it's a success ✅. |
Sorry, something went wrong.
|
Thanks for the reviews; highly appreciated. |
Sorry, something went wrong.
_ioextension module #101819Automerge-Triggered-By: GH:erlend-aasland