◐ Shell
reader mode source ↗
Skip to content

gh-101981: Apply HOMEBREW related environment variables#102074

Merged
corona10 merged 8 commits into
python:mainfrom
corona10:gh-101981-devguide
Feb 20, 2023
Merged

gh-101981: Apply HOMEBREW related environment variables#102074
corona10 merged 8 commits into
python:mainfrom
corona10:gh-101981-devguide

Conversation

@corona10

@corona10 corona10 commented Feb 20, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot mentioned this pull request Feb 20, 2023
Closed
@corona10 corona10 marked this pull request as ready for review February 20, 2023 13:29
@corona10 corona10 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 20, 2023
@bedevere-bot

bedevere-bot commented Feb 20, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10 @erlend-aasland
Update .github/workflows/build.yml …
61b0e25 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@corona10 corona10 requested a review from hugovk February 20, 2023 13:40
@erlend-aasland erlend-aasland changed the title gh-101981: Make macOS CI as same as dev-guide Feb 20, 2023
@erlend-aasland

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

This is nice!

sobolevn
sobolevn reviewed Feb 20, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks @corona10 and @erlend-aasland for fixing the CI 🎉

10 hidden items Load more…
@corona10 corona10 removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 20, 2023
@corona10 corona10 changed the title gh-101981: Combine macOS configure steps as recommended by the devguide Feb 20, 2023
@corona10 corona10 changed the title gh-101981: Apply HOMEBREW related environment variables. Feb 20, 2023
@corona10 corona10 merged commit ed01add into python:main Feb 20, 2023
@corona10 corona10 deleted the gh-101981-devguide branch February 20, 2023 15:20
@erlend-aasland

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Why not backport this?

@corona10 corona10 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 20, 2023
@miss-islington

miss-islington commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Feb 20, 2023

Copy link
Copy Markdown

GH-102081 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 20, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2023
@corona10 @miss-islington
pythongh-101981: Apply HOMEBREW related environment variables (python… …
fc6fd58 
…gh-102074)

(cherry picked from commit ed01add)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot

bedevere-bot commented Feb 20, 2023

Copy link
Copy Markdown

GH-102082 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2023
@corona10 @miss-islington
pythongh-101981: Apply HOMEBREW related environment variables (python… …
9652b51 
…gh-102074)

(cherry picked from commit ed01add)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 20, 2023
@corona10

corona10 commented Feb 20, 2023

Copy link
Copy Markdown
Member Author

Why not backport this?

I thought that it could be a kind of new feature for the CI systems lol.
But after I read the comment from the @zooba at Discord, I change my mind about backporting this.

miss-islington added a commit that referenced this pull request Feb 20, 2023
@miss-islington @corona10
gh-101981: Apply HOMEBREW related environment variables (gh-102074) …
95f4e2c 
(cherry picked from commit ed01add)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
miss-islington added a commit that referenced this pull request Feb 20, 2023
@miss-islington @corona10
gh-101981: Apply HOMEBREW related environment variables (gh-102074) …
1747be4 
(cherry picked from commit ed01add)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 20, 2023
@corona10 @jaraco
pythongh-101981: Apply HOMEBREW related environment variables (python… …
b57a039 
…gh-102074)
@jaraco jaraco mentioned this pull request Feb 20, 2023
Closed
@AlexWaygood AlexWaygood mentioned this pull request Feb 20, 2023
Merged
carljm added a commit to carljm/cpython that referenced this pull request Feb 20, 2023
@carljm
Merge branch 'main' into inlinecomp2 …
9f0fc5b 
* main: (60 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...
@AlexWaygood AlexWaygood mentioned this pull request Feb 21, 2023
Merged
carljm added a commit to carljm/cpython that referenced this pull request Feb 22, 2023
@carljm
Merge branch 'main' into inlinecomp …
544b30c 
* main: (225 commits)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-96161)
  pythongh-101981: Apply HOMEBREW related environment variables (pythongh-102074)
  pythongh-101907: Stop using `_Py_OPCODE` and `_Py_OPARG` macros (pythonGH-101912)
  pythongh-101819: Adapt _io types to heap types, batch 1 (pythonGH-101949)
  pythongh-101981: Build macOS as recommended by the devguide (pythonGH-102070)
  pythongh-97786: Fix compiler warnings in pytime.c (python#101826)
  pythongh-101578: Amend PyErr_{Set,Get}RaisedException docs (python#101962)
  Misc improvements to the float tutorial (pythonGH-102052)
  pythongh-85417: Clarify behaviour on branch cuts in cmath module (python#102046)
  pythongh-100425: Update tutorial docs related to sum() accuracy (FH-101854)
  Add missing 'is' to `cmath.log()` docstring (python#102049)
  pythongh-100210: Correct the comment link for unescaping HTML (python#100212)
  pythongh-97930: Also include subdirectory in makefile. (python#102030)
  pythongh-99735: Use required=True in argparse subparsers example (python#100927)
  Fix incorrectly documented attribute in csv docs (python#101250)
  pythonGH-84783: Make the slice object hashable (pythonGH-101264)
  ...
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@corona10 @python-sidebar
pythongh-101981: Apply HOMEBREW related environment variables (python… …
57cde1f 
…gh-102074)
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@corona10 @python-sidebar
pythongh-101981: Apply HOMEBREW related environment variables (python… …
38f9b35 
…gh-102074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10 @bedevere-bot @erlend-aasland @miss-islington @hugovk @sobolevn