gh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/freeze.py#102152
gh-102151: Correctly fetch CONFIG_ARGS in Tools/freeze/test/freeze.py#102152erlend-aasland merged 1 commit into
Conversation
corona10
left a comment
There was a problem hiding this comment.
Awesome LGTM!
Sorry, something went wrong.
|
Thanks for the review, Dong-hee! I'll wait a day or two for one of the freeze experts to chime in, just in case. |
Sorry, something went wrong.
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
…eze.py (pythonGH-102152) (cherry picked from commit c3a1783) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
…GH-102152) (cherry picked from commit c3a1783) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
This commit has caused https://bugs.gentoo.org/900429 (and https://bugs.gentoo.org/903890 because of the backport to Python 3.11) but it's unclear to me why yet. It leads to a PGO build hanging in test_tools (or running very very slowly) until disk is filled and then it'll move on. |
Sorry, something went wrong.
|
From my understanding which I've reported in https://bugs.gentoo.org/900429#c19 this change didn't directly cause the test_tools to hang. It just fixed another error which was preventing test_tools from starting properly. Before this it quickly failed with: while with this fix it shows different error and then continues for hours and hours (until killed or runs out of disk space or something): 1:44:19 load avg: 1.61 [427/427] test_tools failed (1 error) --- STDERR --- ---- END ---- --- STDERR --- ---- END ---- Total duration: 1 hour 44 min |
Sorry, something went wrong.
|
Thanks Martin. I'm sorry for the noise - I think there is an issue here, but it might be on our end, and it wasn't introduced by this commit (it just exposed some pre-existing issue). |
Sorry, something went wrong.
edited by bedevere-bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.