◐ Shell
reader mode source ↗
Skip to content

gh-102204: Fix endianness issue in AIX#102206

Closed
ayappanec wants to merge 4 commits into
python:mainfrom
ayappanec:gh-102204
Closed

gh-102204: Fix endianness issue in AIX#102206
ayappanec wants to merge 4 commits into
python:mainfrom
ayappanec:gh-102204

Conversation

@ayappanec

@ayappanec ayappanec commented Feb 24, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This PR is to fix the problem mentioned in the issue #102204

@bedevere-bot bedevere-bot mentioned this pull request Feb 24, 2023
Closed
@arhadthedev arhadthedev added the build The build process and cross-build label Feb 24, 2023
@ayappanec

ayappanec commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

Can someone review this ? It's a small change which fixes the _hacl module build in AIX.

@arhadthedev

arhadthedev commented Apr 1, 2023

Copy link
Copy Markdown
Member

@gpshead (as an active core dev who participated in gh-99109 that introduced the file this PR changes).

@gpshead

gpshead commented Apr 2, 2023

Copy link
Copy Markdown
Member

This code comes from the upstream HACL* project, can you also file an issue or PR with them to get AIX-relevant code into https://github.com/hacl-star/hacl-star/blob/main/dist/karamel/include/krml/lowstar_endianness.h?

@gpshead gpshead self-assigned this Apr 2, 2023
This was referenced Apr 3, 2023
Closed
Merged
@gpshead

gpshead commented May 16, 2023

Copy link
Copy Markdown
Member

it looks like this was fixed upstream and we recently pulled in an updated hacl* when the sha3 code was merged. can you check main today and see if there is still any work to be done?

@gpshead gpshead closed this May 20, 2023
@ayappanec

ayappanec commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

it looks like this was fixed upstream and we recently pulled in an updated hacl* when the sha3 code was merged. can you check main today and see if there is still any work to be done?

It works now. Thanks for the support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gpshead gpshead

Labels

awaiting review build The build process and cross-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ayappanec @arhadthedev @gpshead @bedevere-bot