◐ Shell
reader mode source ↗
Skip to content

gh-101765: Fix refcount issues in list and unicode pickling#102265

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:refcount
Feb 26, 2023
Merged

gh-101765: Fix refcount issues in list and unicode pickling#102265
JelleZijlstra merged 1 commit into
python:mainfrom
JelleZijlstra:refcount

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Feb 25, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra added skip news 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Feb 25, 2023
@bedevere-bot

bedevere-bot commented Feb 25, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit b8ad59e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot added awaiting core review and removed 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Feb 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 25, 2023
Closed
iritkatriel
iritkatriel approved these changes Feb 26, 2023
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 26, 2023
@JelleZijlstra JelleZijlstra merged commit d71edbd into python:main Feb 26, 2023
@miss-islington

miss-islington commented Feb 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@JelleZijlstra JelleZijlstra deleted the refcount branch February 26, 2023 00:02
@miss-islington

miss-islington commented Feb 26, 2023

Copy link
Copy Markdown
Contributor

Sorry, @JelleZijlstra, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d71edbd1b7437706519a9786211597d95934331a 3.11

@miss-islington

miss-islington commented Feb 26, 2023

Copy link
Copy Markdown
Contributor

Sorry @JelleZijlstra, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker d71edbd1b7437706519a9786211597d95934331a 3.10

@JelleZijlstra

JelleZijlstra commented Feb 26, 2023

Copy link
Copy Markdown
Member Author

Working on the backports

@bedevere-bot

bedevere-bot commented Feb 26, 2023

Copy link
Copy Markdown

GH-102268 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 26, 2023
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request Feb 26, 2023
@JelleZijlstra
[3.11] pythongh-101765: Fix refcount issues in list and unicode pickl… …
e97ddc6 
…ing (pythonGH-102265)

Followup from pythonGH-101769..
(cherry picked from commit d71edbd)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 26, 2023

Copy link
Copy Markdown

GH-102269 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 26, 2023
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request Feb 26, 2023
@JelleZijlstra
[3.10] pythongh-101765: Fix refcount issues in list and unicode pickl… …
fca504e 
…ing (pythonGH-102265)

Followup from pythonGH-101769..
(cherry picked from commit d71edbd)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra added a commit that referenced this pull request Feb 26, 2023
@JelleZijlstra
[3.10] gh-101765: Fix refcount issues in list and unicode pickling (G… …
6fa6c2a 
…H-102265) (#102269)

(cherry picked from commit d71edbd)
JelleZijlstra added a commit that referenced this pull request Feb 26, 2023
@JelleZijlstra
[3.11] gh-101765: Fix refcount issues in list and unicode pickling (G… …
b36c498 
…H-102265) (#102268)

(cherry picked from commit d71edbd)
@JelleZijlstra JelleZijlstra mentioned this pull request Feb 26, 2023
Merged
@ericsnowcurrently ericsnowcurrently mentioned this pull request Feb 27, 2023
Merged
@JelleZijlstra JelleZijlstra restored the refcount branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JelleZijlstra @bedevere-bot @miss-islington @iritkatriel @kumaraditya303