{{ message }}
Remove the unused import 'warnings' from unittest's loader module#102479
Merged
AlexWaygood merged 1 commit intoMar 6, 2023
Merged
Remove the unused import 'warnings' from unittest's loader module#102479AlexWaygood merged 1 commit into
AlexWaygood merged 1 commit into
Conversation
Contributor
Sorry, something went wrong.
Warnings is lazily imported in this file prior to use.
AlexWaygood
approved these changes
Mar 6, 2023
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Member
|
(I checked, the import is actually used on the 3.11 branch, so this can't be backported.) |
Sorry, something went wrong.
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Mar 7, 2023
* main: pythongh-102493: fix normalization in PyErr_SetObject (python#102502) pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320) pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781) Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398) pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429) pythongh-90110: Fix the c-analyzer Tool (python#102483) pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485) Remove unused import of `warnings` from `unittest.loader` (python#102479) Add gettext support to tools/extensions/c_annotations.py (python#101989)
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Mar 8, 2023
* main: pythongh-102493: fix normalization in PyErr_SetObject (python#102502) pythongh-87092: compiler's CFG construction moved to after codegen stage (python#102320) pythongh-95913: Consolidate build requirements changes in 3.11 WhatsNew (pythonGH-98781) Remove redundant `_ensure_future` in favor of `ensure_future` in `asyncio` (python#102398) pythongh-95913: Edit Faster CPython section in 3.11 WhatsNew (pythonGH-98429) pythongh-90110: Fix the c-analyzer Tool (python#102483) pythongh-101759: Update macOS installer SQLite 3.40.1 checksum (pythongh-102485) Remove unused import of `warnings` from `unittest.loader` (python#102479) Add gettext support to tools/extensions/c_annotations.py (python#101989)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Not the most glamorous PR, but the import isn't being used and is imported every time
$python -m unittestis run.