◐ Shell
reader mode source ↗
Skip to content

gh-79940: skip TestGetAsyncGenState on wasm as it requires working sockets#102605

Merged
miss-islington merged 2 commits into
python:mainfrom
tkren:fix-pr-11590-test-inspect
Mar 11, 2023
Merged

gh-79940: skip TestGetAsyncGenState on wasm as it requires working sockets#102605
miss-islington merged 2 commits into
python:mainfrom
tkren:fix-pr-11590-test-inspect

Conversation

@tkren

@tkren tkren commented Mar 11, 2023 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Skip TestGetAsyncGenState and restoring of the default event loop policy in test_inspect if platform lacks working socket support.

Fixes #11590

Automerge-Triggered-By: GH:kumaraditya303

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 11, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 11, 2023
Closed
@tkren tkren force-pushed the fix-pr-11590-test-inspect branch from 2c44e3b to 184f617 Compare March 11, 2023 16:15
@tkren
TestGetAsyncGenState requires working sockets …
6ab6bcf 
Skip `TestGetAsyncGenState` and restoring of the default event loop
policy in `test_inspect` if platform lacks working socket support.

Fixes python#11590
@tkren tkren force-pushed the fix-pr-11590-test-inspect branch from 184f617 to 6ab6bcf Compare March 11, 2023 16:28
@tkren

tkren commented Mar 11, 2023

Copy link
Copy Markdown
Contributor Author

@kumaraditya303 this is the follow-up PR for #11590

@kumaraditya303

kumaraditya303 commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

!buildbot .wasm.

@bedevere-bot

bedevere-bot commented Mar 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 6ab6bcf 🤖

The command will test the builders whose names match following regular expression: .*wasm.*

The builders matched are:

  • wasm32-emscripten node (pthreads) PR
  • wasm32-emscripten browser (dynamic linking, no tests) PR
  • wasm32-wasi PR
  • wasm32-emscripten node (dynamic linking) PR

kumaraditya303
kumaraditya303 approved these changes Mar 11, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks, we don't need news for this so I removed it.

@kumaraditya303 kumaraditya303 changed the title gh-79940: TestGetAsyncGenState requires working sockets Mar 11, 2023
@miss-islington

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

@miss-islington

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Head branch was modified. Review and try the merge again..

@miss-islington

miss-islington commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 534660f into python:main Mar 11, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Mar 12, 2023
@tkren @iritkatriel
pythongh-79940: skip TestGetAsyncGenState on wasm as it requires wo… …
45cc601 
…rking sockets (pythonGH-102605)

Skip `TestGetAsyncGenState` and restoring of the default event loop policy in `test_inspect` if platform lacks working socket support.

Fixes python#11590

Automerge-Triggered-By: GH:kumaraditya303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tkren @kumaraditya303 @bedevere-bot @miss-islington