◐ Shell
reader mode source ↗
Skip to content

GH-63062: Implement __subclasshook__() for Finders and Loaders in abc lib#102763

Closed
furkanonder wants to merge 4 commits into
python:mainfrom
furkanonder:issue-63062
Closed

GH-63062: Implement __subclasshook__() for Finders and Loaders in abc lib#102763
furkanonder wants to merge 4 commits into
python:mainfrom
furkanonder:issue-63062

Conversation

@furkanonder

@furkanonder furkanonder commented Mar 16, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot mentioned this pull request Mar 16, 2023
Open
@brettcannon

brettcannon commented May 12, 2023

Copy link
Copy Markdown
Member

FYI there's a merge conflict.

@brettcannon brettcannon removed their request for review June 9, 2023 22:29
@brettcannon

brettcannon commented Jun 9, 2023

Copy link
Copy Markdown
Member

To keep my review queue clean, I'm removing myself to review until the merge conflict is fixed. Feel free to add me back once the conflict is fixed.

@furkanonder

furkanonder commented Jun 10, 2023

Copy link
Copy Markdown
Contributor Author

This PR seems to deprecate find_loader and find_module. For this reason I think it makes sense to close the PR. @brettcannon What do you think?

@brettcannon

brettcannon commented Jun 16, 2023

Copy link
Copy Markdown
Member

@furkanonder it's your PR so if you think it should be closed I'm fine with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@furkanonder @brettcannon @bedevere-bot