◐ Shell
reader mode source ↗
Skip to content

gh-102509: Ignore acceptable access of an uninitialized value#102838

Closed
illia-v wants to merge 3 commits into
python:mainfrom
illia-v:gh-102509-ignorelist
Closed

gh-102509: Ignore acceptable access of an uninitialized value#102838
illia-v wants to merge 3 commits into
python:mainfrom
illia-v:gh-102509-ignorelist

Conversation

@illia-v

@illia-v illia-v commented Mar 20, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This is done to ignore an error on accessing an uninitialized integer without an adverse effect.
#102509 (comment)

@bedevere-bot bedevere-bot mentioned this pull request Mar 20, 2023
Closed
@illia-v illia-v changed the title gh-102509: Create an ignore list for sanitizers Mar 20, 2023
@erlend-aasland

erlend-aasland commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

AFAICS, this is an alternative to #102510. Let's wait an see what the Marks decide over there first.

@erlend-aasland erlend-aasland marked this pull request as draft March 22, 2023 10:02
@erlend-aasland erlend-aasland removed their request for review May 8, 2023 07:55
@arhadthedev

arhadthedev commented May 11, 2023

Copy link
Copy Markdown
Member

Let's wait an see what the Marks decide over there first.

@mdickinson

@illia-v

illia-v commented May 17, 2023

Copy link
Copy Markdown
Contributor Author

It will be nice to have the error fixed in the first beta of 3.12.

I've just checked that #101291 has not affected the use of the uninitialized value yet (see #102510 (comment) for previous expectations) and running CC=clang ./configure --with-memory-sanitizer && make -j12 still fails without the patch.

@mdickinson

mdickinson commented May 20, 2023

Copy link
Copy Markdown
Member

@arhadthedev

@mdickinson

I think this one's for @markshannon to decide; he has better awareness of the #102510 performance trade-offs than I do. (And it's "his" code, in some sense.)

@illia-v

illia-v commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Closing this because the value was initialized explicitly in #102510 and #107464

@illia-v illia-v closed this Jul 31, 2023
@illia-v illia-v deleted the gh-102509-ignorelist branch July 31, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner

@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@illia-v @erlend-aasland @arhadthedev @mdickinson @bedevere-bot