{{ message }}
[WIP] bpo-35134: Create Include/pycapi/ subdirectory#10285
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
Member
Sorry, something went wrong.
* Create Include/pycapi/ subdirectory * "make install" now creates $prefix/include/pycapi and copy Include/pycapi/* to $prefix/include/pycapi * Create Include/pycapi/pycapi_objimpl.h: move objimpl.h code surrounded by #ifndef Py_LIMITED_API to pycapi_objimpl.h. * objimpl.h includes pycapi/pycapi_objimpl.h
vstinner
requested review from
ericsnowcurrently,
ncoghlan and
serhiy-storchaka
November 1, 2018 13:04
vstinner
commented
Nov 1, 2018
Member
Author
|
I abandon this PR: moving PyObject_Calloc() was wrong, and "pycapi" name is too generic: I created a new PR #10624. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Include/pycapi/* to $prefix/include/pycapi
surrounded by #ifndef Py_LIMITED_API to pycapi_objimpl.h.
https://bugs.python.org/issue35134