◐ Shell
reader mode source ↗
Skip to content

Doc: Simplify Copyright line in README#10287

Merged
miss-islington merged 1 commit into
python:masterfrom
davidak:patch-1
Nov 10, 2018
Merged

Doc: Simplify Copyright line in README#10287
miss-islington merged 1 commit into
python:masterfrom
davidak:patch-1

Conversation

@davidak

@davidak davidak commented Nov 1, 2018 •
edited by Mariatta
Loading

Copy link
Copy Markdown
Contributor

This also makes it consistent with other places like:

@davidak
Doc: Simplify Copyright line in README …
0963a56 
This also makes it consistent with other places like:

- https://docs.python.org/dev/copyright.html
- https://www.python.org/ footer
- https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Python/getcopyright.c#L7

This is my first contribution to python, completely done using GitHubs webinterface. I will sign the CLA later today.
@the-knights-who-say-ni

the-knights-who-say-ni commented Nov 1, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 1, 2018
@JulienPalard JulienPalard requested a review from VanL November 3, 2018 22:51
@matrixise

matrixise commented Nov 4, 2018

Copy link
Copy Markdown
Member

For me, it's ok, we have some references where the copyright by the PSF is from 2001-2018. We could merge it after the review of @VanL .

@VanL

VanL commented Nov 7, 2018

Copy link
Copy Markdown
Member

This is fine with me.

@Mariatta

Mariatta commented Nov 8, 2018

Copy link
Copy Markdown
Member

I beleieve there is an issue in bpo about the copyright. I'll have to look it up and link it here.

@ned-deily

ned-deily commented Nov 9, 2018

Copy link
Copy Markdown
Member

@Mariatta, Are you thinking of https://bugs.python.org/issue29555 ? That also covers copyright dates in a number of modules.

@Mariatta

Mariatta commented Nov 9, 2018

Copy link
Copy Markdown
Member

Ah yeah that's the issue I was thinking.

gvanrossum
gvanrossum approved these changes Nov 10, 2018
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@miss-islington miss-islington merged commit 9d43fa1 into python:master Nov 10, 2018
@Mariatta

Mariatta commented Nov 10, 2018

Copy link
Copy Markdown
Member

Thanks @davidak and congrats on your first contribution to CPython 🌮

@davidak davidak deleted the patch-1 branch November 10, 2018 16:25
Stevoisiak added a commit to Stevoisiak/cpython that referenced this pull request Feb 8, 2023
@Stevoisiak
Doc: Use a range of years for copyright in LICENSE …
2f50c05 
Uses a range of years for the copyright in LICENSE file. Follows up on python#10287 and makes it consistent with other copyright notices).
This was referenced Feb 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matrixise matrixise matrixise approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@Mariatta Mariatta

+1 more reviewer

@VanL VanL VanL approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@davidak @the-knights-who-say-ni @matrixise @VanL @Mariatta @ned-deily @gvanrossum @bedevere-bot @miss-islington