◐ Shell
reader mode source ↗
Skip to content

gh-102950: Implement PEP 706 – Filter for tarfile.extractall#102953

Merged
encukou merged 16 commits into
python:mainfrom
encukou:tarfile-dir-traversal-sqsq
Apr 24, 2023
Merged

gh-102950: Implement PEP 706 – Filter for tarfile.extractall#102953
encukou merged 16 commits into
python:mainfrom
encukou:tarfile-dir-traversal-sqsq

Conversation

@encukou

@encukou encukou commented Mar 23, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

See PEP-706 for details.

I might have overengineered the tests a bit, moving boilerplate to a set of helpers. Hopefully the tests themselves are clear enough to make it worth it.

@encukou encukou requested a review from gpshead March 23, 2023 14:21
@encukou encukou requested a review from ethanfurman as a code owner March 23, 2023 14:21
@bedevere-bot bedevere-bot mentioned this pull request Mar 23, 2023
Closed
1 task
ethanfurman
ethanfurman requested changes Mar 23, 2023
View reviewed changes

@ethanfurman ethanfurman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Here's what I have so far; still working on tarfile.py.

@bedevere-bot

bedevere-bot commented Mar 23, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@encukou

encukou commented Mar 31, 2023

Copy link
Copy Markdown
Member Author

@gpshead, did you want to take a look?

@encukou

encukou commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Apr 3, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ethanfurman April 3, 2023 15:49
hroncok
hroncok reviewed Apr 4, 2023
View reviewed changes

@hroncok hroncok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I reviewed the changes in Doc/.

2 hidden conversations Load more…
gpshead
gpshead reviewed Apr 5, 2023
View reviewed changes
7 hidden conversations Load more…
@encukou

encukou commented Apr 17, 2023

Copy link
Copy Markdown
Member Author

If there are no objections, I plan to merge this around Wednesday. Please let me know if you're working on a review.

36 hidden items Load more…
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 20, 2023
@bedevere-bot

bedevere-bot commented Apr 20, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit a255634 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 20, 2023
@encukou

encukou commented Apr 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

The remaining buildbot failures are unrelated and happened on main builds as well. One was fixed in main (#103561) and the other is still there.
Crossing fingers, merging.

@encukou encukou merged commit af53046 into python:main Apr 24, 2023
@encukou encukou deleted the tarfile-dir-traversal-sqsq branch April 24, 2023 08:58
@kulikjak

kulikjak commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

Hi, with this integrated, I see one new test failure on Solaris:

FAIL: test_modes (test.test_tarfile.TestExtractionFilters.test_modes)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "...../cpython-main/Lib/test/test_tarfile.py", line 3641, in test_modes
    self.expect_file('all_bits', mode='?rwsrwsrwt')
  File "...../cpython-main/Lib/test/test_tarfile.py", line 3406, in expect_file
    self.assertEqual(got, mode)
AssertionError: '?rwsrwsrwx' != '?rwsrwsrwt'
- ?rwsrwsrwx
?          ^
+ ?rwsrwsrwt
?          ^

The issue seems to be the fact that setting sticky bit on files as regular user doesn't do anything on Solaris, and from my limited testing, the same seems to be true on some other systems as well (I tried FreeBSD and chmod +t on file as a regular user also did nothing).

@encukou

encukou commented Apr 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Thanks for the report! The tests are intentionally pretty strict. I'll relax this one. (Edit: see #103831)

encukou added a commit that referenced this pull request Apr 28, 2023
@encukou
[3.11] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (G… …
241f2e5 
…H-102953) (GH-103832)

See [Backporting & Forward Compatibility in PEP 706](https://peps.python.org/pep-0706/#backporting-forward-compatibility).

- Backport b52ad18
- Backport c8c3956
- Remove the DeprecationWarning
- Adjust docs
- Remove new `__all__` entries
@mcepl mcepl mentioned this pull request May 3, 2023
Merged
@bedevere-bot

bedevere-bot commented May 3, 2023

Copy link
Copy Markdown

GH-104128 is a backport of this pull request to the 3.10 branch.

@bedevere-bot

bedevere-bot commented May 9, 2023

Copy link
Copy Markdown

GH-104327 is a backport of this pull request to the 3.10 branch.

encukou added a commit that referenced this pull request May 10, 2023
@mcepl @encukou
[3.10] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (G… …
425065b 
…H-102953) (GH-104128)

- Backport b52ad18
- Backport c8c3956
- Remove the DeprecationWarning
- Adjust docs
- Remove new `__all__` entries

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-bot

bedevere-bot commented May 11, 2023

Copy link
Copy Markdown

GH-104382 is a backport of this pull request to the 3.9 branch.

ambv pushed a commit that referenced this pull request May 15, 2023
@encukou
[3.9] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (G… …
98016f7 
…H-102953) (#104382)

Backport of c8c3956
@bedevere-bot

bedevere-bot commented May 15, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 3.9 has failed when building commit 98016f7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/250/builds/532) and take a look at the build logs.
  4. Check if the failure is related to this commit (98016f7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/250/builds/532

Failed tests:

  • test_gdb

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 4271, done.        
remote: Counting objects:   0% (1/2543)        
remote: Counting objects:   1% (26/2543)        
remote: Counting objects:   2% (51/2543)        
remote: Counting objects:   3% (77/2543)        
remote: Counting objects:   4% (102/2543)        
remote: Counting objects:   5% (128/2543)        
remote: Counting objects:   6% (153/2543)        
remote: Counting objects:   7% (179/2543)        
remote: Counting objects:   8% (204/2543)        
remote: Counting objects:   9% (229/2543)        
remote: Counting objects:  10% (255/2543)        
remote: Counting objects:  11% (280/2543)        
remote: Counting objects:  12% (306/2543)        
remote: Counting objects:  13% (331/2543)        
remote: Counting objects:  14% (357/2543)        
remote: Counting objects:  15% (382/2543)        
remote: Counting objects:  16% (407/2543)        
remote: Counting objects:  17% (433/2543)        
remote: Counting objects:  18% (458/2543)        
remote: Counting objects:  19% (484/2543)        
remote: Counting objects:  20% (509/2543)        
remote: Counting objects:  21% (535/2543)        
remote: Counting objects:  22% (560/2543)        
remote: Counting objects:  23% (585/2543)        
remote: Counting objects:  24% (611/2543)        
remote: Counting objects:  25% (636/2543)        
remote: Counting objects:  26% (662/2543)        
remote: Counting objects:  27% (687/2543)        
remote: Counting objects:  28% (713/2543)        
remote: Counting objects:  29% (738/2543)        
remote: Counting objects:  30% (763/2543)        
remote: Counting objects:  31% (789/2543)        
remote: Counting objects:  32% (814/2543)        
remote: Counting objects:  33% (840/2543)        
remote: Counting objects:  34% (865/2543)        
remote: Counting objects:  35% (891/2543)        
remote: Counting objects:  36% (916/2543)        
remote: Counting objects:  37% (941/2543)        
remote: Counting objects:  38% (967/2543)        
remote: Counting objects:  39% (992/2543)        
remote: Counting objects:  40% (1018/2543)        
remote: Counting objects:  41% (1043/2543)        
remote: Counting objects:  42% (1069/2543)        
remote: Counting objects:  43% (1094/2543)        
remote: Counting objects:  44% (1119/2543)        
remote: Counting objects:  45% (1145/2543)        
remote: Counting objects:  46% (1170/2543)        
remote: Counting objects:  47% (1196/2543)        
remote: Counting objects:  48% (1221/2543)        
remote: Counting objects:  49% (1247/2543)        
remote: Counting objects:  50% (1272/2543)        
remote: Counting objects:  51% (1297/2543)        
remote: Counting objects:  52% (1323/2543)        
remote: Counting objects:  53% (1348/2543)        
remote: Counting objects:  54% (1374/2543)        
remote: Counting objects:  55% (1399/2543)        
remote: Counting objects:  56% (1425/2543)        
remote: Counting objects:  57% (1450/2543)        
remote: Counting objects:  58% (1475/2543)        
remote: Counting objects:  59% (1501/2543)        
remote: Counting objects:  60% (1526/2543)        
remote: Counting objects:  61% (1552/2543)        
remote: Counting objects:  62% (1577/2543)        
remote: Counting objects:  63% (1603/2543)        
remote: Counting objects:  64% (1628/2543)        
remote: Counting objects:  65% (1653/2543)        
remote: Counting objects:  66% (1679/2543)        
remote: Counting objects:  67% (1704/2543)        
remote: Counting objects:  68% (1730/2543)        
remote: Counting objects:  69% (1755/2543)        
remote: Counting objects:  70% (1781/2543)        
remote: Counting objects:  71% (1806/2543)        
remote: Counting objects:  72% (1831/2543)        
remote: Counting objects:  73% (1857/2543)        
remote: Counting objects:  74% (1882/2543)        
remote: Counting objects:  75% (1908/2543)        
remote: Counting objects:  76% (1933/2543)        
remote: Counting objects:  77% (1959/2543)        
remote: Counting objects:  78% (1984/2543)        
remote: Counting objects:  79% (2009/2543)        
remote: Counting objects:  80% (2035/2543)        
remote: Counting objects:  81% (2060/2543)        
remote: Counting objects:  82% (2086/2543)        
remote: Counting objects:  83% (2111/2543)        
remote: Counting objects:  84% (2137/2543)        
remote: Counting objects:  85% (2162/2543)        
remote: Counting objects:  86% (2187/2543)        
remote: Counting objects:  87% (2213/2543)        
remote: Counting objects:  88% (2238/2543)        
remote: Counting objects:  89% (2264/2543)        
remote: Counting objects:  90% (2289/2543)        
remote: Counting objects:  91% (2315/2543)        
remote: Counting objects:  92% (2340/2543)        
remote: Counting objects:  93% (2365/2543)        
remote: Counting objects:  94% (2391/2543)        
remote: Counting objects:  95% (2416/2543)        
remote: Counting objects:  96% (2442/2543)        
remote: Counting objects:  97% (2467/2543)        
remote: Counting objects:  98% (2493/2543)        
remote: Counting objects:  99% (2518/2543)        
remote: Counting objects: 100% (2543/2543)        
remote: Counting objects: 100% (2543/2543), done.        
remote: Compressing objects:   9% (1/11)        
remote: Compressing objects:  18% (2/11)        
remote: Compressing objects:  27% (3/11)        
remote: Compressing objects:  36% (4/11)        
remote: Compressing objects:  45% (5/11)        
remote: Compressing objects:  54% (6/11)        
remote: Compressing objects:  63% (7/11)        
remote: Compressing objects:  72% (8/11)        
remote: Compressing objects:  81% (9/11)        
remote: Compressing objects:  90% (10/11)        
remote: Compressing objects: 100% (11/11)        
remote: Compressing objects: 100% (11/11), done.        
Receiving objects:   0% (1/4271)
Receiving objects:   1% (43/4271)
Receiving objects:   2% (86/4271)
Receiving objects:   3% (129/4271)
Receiving objects:   4% (171/4271)
Receiving objects:   5% (214/4271)
Receiving objects:   6% (257/4271)
Receiving objects:   7% (299/4271)
Receiving objects:   8% (342/4271)
Receiving objects:   9% (385/4271)
Receiving objects:  10% (428/4271)
Receiving objects:  11% (470/4271)
Receiving objects:  12% (513/4271)
Receiving objects:  13% (556/4271)
Receiving objects:  14% (598/4271)
Receiving objects:  15% (641/4271)
Receiving objects:  16% (684/4271)
Receiving objects:  17% (727/4271)
Receiving objects:  18% (769/4271)
Receiving objects:  19% (812/4271)
Receiving objects:  20% (855/4271)
Receiving objects:  21% (897/4271)
Receiving objects:  22% (940/4271)
Receiving objects:  23% (983/4271)
Receiving objects:  24% (1026/4271)
Receiving objects:  25% (1068/4271)
Receiving objects:  26% (1111/4271)
Receiving objects:  27% (1154/4271)
Receiving objects:  28% (1196/4271)
Receiving objects:  29% (1239/4271)
Receiving objects:  30% (1282/4271)
Receiving objects:  31% (1325/4271)
Receiving objects:  32% (1367/4271)
Receiving objects:  33% (1410/4271)
Receiving objects:  34% (1453/4271)
Receiving objects:  35% (1495/4271)
Receiving objects:  36% (1538/4271)
Receiving objects:  37% (1581/4271)
Receiving objects:  38% (1623/4271)
Receiving objects:  39% (1666/4271)
Receiving objects:  40% (1709/4271)
Receiving objects:  41% (1752/4271)
Receiving objects:  42% (1794/4271)
Receiving objects:  43% (1837/4271)
Receiving objects:  44% (1880/4271)
Receiving objects:  45% (1922/4271)
Receiving objects:  46% (1965/4271)
Receiving objects:  47% (2008/4271)
Receiving objects:  48% (2051/4271)
Receiving objects:  49% (2093/4271)
Receiving objects:  50% (2136/4271)
Receiving objects:  51% (2179/4271)
Receiving objects:  52% (2221/4271)
Receiving objects:  53% (2264/4271)
Receiving objects:  54% (2307/4271)
Receiving objects:  55% (2350/4271)
Receiving objects:  56% (2392/4271)
Receiving objects:  57% (2435/4271)
Receiving objects:  58% (2478/4271)
Receiving objects:  59% (2520/4271)
Receiving objects:  60% (2563/4271)
Receiving objects:  61% (2606/4271)
Receiving objects:  62% (2649/4271)
Receiving objects:  63% (2691/4271)
Receiving objects:  64% (2734/4271)
Receiving objects:  65% (2777/4271)
Receiving objects:  66% (2819/4271)
Receiving objects:  67% (2862/4271)
Receiving objects:  68% (2905/4271)
Receiving objects:  69% (2947/4271)
Receiving objects:  70% (2990/4271)
Receiving objects:  71% (3033/4271)
Receiving objects:  72% (3076/4271)
Receiving objects:  73% (3118/4271)
Receiving objects:  74% (3161/4271)
Receiving objects:  75% (3204/4271)
Receiving objects:  76% (3246/4271)
Receiving objects:  77% (3289/4271)
Receiving objects:  78% (3332/4271)
Receiving objects:  79% (3375/4271)
Receiving objects:  80% (3417/4271)
Receiving objects:  81% (3460/4271)
Receiving objects:  82% (3503/4271)
Receiving objects:  83% (3545/4271)
Receiving objects:  84% (3588/4271)
Receiving objects:  85% (3631/4271)
Receiving objects:  86% (3674/4271)
Receiving objects:  87% (3716/4271)
Receiving objects:  88% (3759/4271)
Receiving objects:  89% (3802/4271)
Receiving objects:  90% (3844/4271)
Receiving objects:  91% (3887/4271)
Receiving objects:  92% (3930/4271)
Receiving objects:  93% (3973/4271)
Receiving objects:  94% (4015/4271)
Receiving objects:  95% (4058/4271)
Receiving objects:  96% (4101/4271)
remote: Total 4271 (delta 2532), reused 2533 (delta 2532), pack-reused 1728        
Receiving objects:  97% (4143/4271)
Receiving objects:  98% (4186/4271)
Receiving objects:  99% (4229/4271)
Receiving objects: 100% (4271/4271)
Receiving objects: 100% (4271/4271), 6.59 MiB | 14.11 MiB/s, done.
Resolving deltas:   0% (0/3368)
Resolving deltas:   1% (34/3368)
Resolving deltas:   2% (68/3368)
Resolving deltas:   3% (102/3368)
Resolving deltas:   4% (135/3368)
Resolving deltas:   5% (169/3368)
Resolving deltas:   6% (203/3368)
Resolving deltas:   7% (236/3368)
Resolving deltas:   8% (270/3368)
Resolving deltas:   9% (304/3368)
Resolving deltas:  10% (337/3368)
Resolving deltas:  11% (371/3368)
Resolving deltas:  12% (405/3368)
Resolving deltas:  13% (438/3368)
Resolving deltas:  14% (472/3368)
Resolving deltas:  15% (506/3368)
Resolving deltas:  16% (539/3368)
Resolving deltas:  17% (573/3368)
Resolving deltas:  18% (607/3368)
Resolving deltas:  19% (640/3368)
Resolving deltas:  20% (674/3368)
Resolving deltas:  21% (708/3368)
Resolving deltas:  22% (741/3368)
Resolving deltas:  23% (775/3368)
Resolving deltas:  24% (809/3368)
Resolving deltas:  25% (842/3368)
Resolving deltas:  26% (876/3368)
Resolving deltas:  27% (910/3368)
Resolving deltas:  28% (944/3368)
Resolving deltas:  29% (977/3368)
Resolving deltas:  30% (1011/3368)
Resolving deltas:  31% (1045/3368)
Resolving deltas:  32% (1078/3368)
Resolving deltas:  33% (1112/3368)
Resolving deltas:  34% (1146/3368)
Resolving deltas:  35% (1179/3368)
Resolving deltas:  36% (1213/3368)
Resolving deltas:  37% (1247/3368)
Resolving deltas:  38% (1280/3368)
Resolving deltas:  39% (1314/3368)
Resolving deltas:  40% (1348/3368)
Resolving deltas:  41% (1381/3368)
Resolving deltas:  42% (1415/3368)
Resolving deltas:  43% (1449/3368)
Resolving deltas:  44% (1482/3368)
Resolving deltas:  45% (1516/3368)
Resolving deltas:  46% (1550/3368)
Resolving deltas:  47% (1583/3368)
Resolving deltas:  48% (1617/3368)
Resolving deltas:  49% (1651/3368)
Resolving deltas:  50% (1684/3368)
Resolving deltas:  51% (1718/3368)
Resolving deltas:  52% (1752/3368)
Resolving deltas:  53% (1786/3368)
Resolving deltas:  54% (1819/3368)
Resolving deltas:  55% (1853/3368)
Resolving deltas:  56% (1887/3368)
Resolving deltas:  57% (1920/3368)
Resolving deltas:  58% (1954/3368)
Resolving deltas:  58% (1954/3368)
Resolving deltas:  59% (1988/3368)
Resolving deltas:  60% (2021/3368)
Resolving deltas:  61% (2055/3368)
Resolving deltas:  62% (2089/3368)
Resolving deltas:  63% (2122/3368)
Resolving deltas:  64% (2156/3368)
Resolving deltas:  65% (2190/3368)
Resolving deltas:  66% (2223/3368)
Resolving deltas:  67% (2257/3368)
Resolving deltas:  68% (2291/3368)
Resolving deltas:  69% (2324/3368)
Resolving deltas:  70% (2358/3368)
Resolving deltas:  71% (2392/3368)
Resolving deltas:  71% (2398/3368)
Resolving deltas:  72% (2425/3368)
Resolving deltas:  73% (2459/3368)
Resolving deltas:  74% (2493/3368)
Resolving deltas:  75% (2526/3368)
Resolving deltas:  75% (2537/3368)
Resolving deltas:  76% (2560/3368)
Resolving deltas:  77% (2594/3368)
Resolving deltas:  78% (2628/3368)
Resolving deltas:  79% (2661/3368)
Resolving deltas:  80% (2695/3368)
Resolving deltas:  81% (2729/3368)
Resolving deltas:  81% (2737/3368)
Resolving deltas:  82% (2762/3368)
Resolving deltas:  83% (2796/3368)
Resolving deltas:  84% (2830/3368)
Resolving deltas:  85% (2863/3368)
Resolving deltas:  86% (2897/3368)
Resolving deltas:  87% (2931/3368)
Resolving deltas:  88% (2964/3368)
Resolving deltas:  89% (2998/3368)
Resolving deltas:  90% (3032/3368)
Resolving deltas:  91% (3065/3368)
Resolving deltas:  91% (3086/3368)
Resolving deltas:  92% (3099/3368)
Resolving deltas:  93% (3133/3368)
Resolving deltas:  94% (3166/3368)
Resolving deltas:  95% (3200/3368)
Resolving deltas:  96% (3234/3368)
Resolving deltas:  97% (3267/3368)
Resolving deltas:  98% (3301/3368)
Resolving deltas:  99% (3335/3368)
Resolving deltas:  99% (3340/3368)
Resolving deltas: 100% (3368/3368)
Resolving deltas: 100% (3368/3368), completed with 737 local objects.
From https://github.com/python/cpython
 * branch                  3.9        -> FETCH_HEAD
 * [new tag]               v3.10.11   -> v3.10.11
 * [new tag]               v3.11.3    -> v3.11.3
 * [new tag]               v3.12.0a7  -> v3.12.0a7
Note: switching to '98016f7c92aa4c1232c68bac1ed6646db31782ec'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 98016f7c92 [3.9] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) (#104382)
Switched to and reset branch '3.9'

configure: WARNING: unrecognized options: --without-static-libpython
configure: WARNING: unrecognized options: --without-static-libpython

../Modules/_threadmodule.c: In function ‘local_clear’:
../Modules/_threadmodule.c:812:20: warning: unused variable ‘tstate’ [-Wunused-variable]
     PyThreadState *tstate;
                    ^~~~~~

test_startfile skipped -- object <module 'os' from '/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/build_oot/../Lib/os.py'> has no attribute 'startfile'
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_devpoll skipped -- test works only on Solaris OS family
test_winsound skipped -- No module named 'winsound'
test_ioctl skipped -- Unable to open /dev/tty
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
<string>:2: PendingDeprecationWarning: lib2to3 package is deprecated and may not be able to parse Python 3.10+
test_winconsoleio skipped -- test only relevant on win32
test_winreg skipped -- No module named 'winreg'
test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_msilib skipped -- No module named '_msi'
test_kqueue skipped -- test works only on BSD
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 9.641s

OK (skipped=2)
Timeout (0:15:00)!
Thread 0x00007fff90ff5340 (most recent call first):
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/selectors.py", line 416 in select
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/subprocess.py", line 1995 in _communicate
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/subprocess.py", line 1134 in communicate
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 112 in run_gdb
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 226 in get_stack_trace
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 909 in test_pycfunction
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 550 in _callTestMethod
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 592 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 651 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/runner.py", line 184 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/support/__init__.py", line 1850 in _run_suite
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/support/__init__.py", line 1974 in run_unittest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 263 in _test_module
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 288 in _runtest_inner2
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 326 in _runtest_inner
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 204 in _runtest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 247 in runtest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest_mp.py", line 83 in run_tests_worker
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 692 in _main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 672 in main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 733 in main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/regrtest.py", line 43 in _main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/regrtest.py", line 47 in <module>
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/runpy.py", line 87 in _run_code
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/runpy.py", line 197 in _run_module_as_main
Timeout (0:15:00)!
Thread 0x00007fff911f5340 (most recent call first):
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/selectors.py", line 416 in select
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/subprocess.py", line 1995 in _communicate
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/subprocess.py", line 1134 in communicate
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 112 in run_gdb
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 226 in get_stack_trace
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 920 in test_pycfunction
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 550 in _callTestMethod
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 592 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 651 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/runner.py", line 184 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/support/__init__.py", line 1850 in _run_suite
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/support/__init__.py", line 1974 in run_unittest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 263 in _test_module
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 288 in _runtest_inner2
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 326 in _runtest_inner
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 217 in _runtest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 247 in runtest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 334 in rerun_failed_tests
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 716 in _main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 672 in main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 733 in main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/runpy.py", line 87 in _run_code
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/runpy.py", line 197 in _run_module_as_main
make: *** [Makefile:1240: buildbottest] Error 1

Cannot open file '/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/build_oot/test-results.xml' for upload

@bedevere-bot

bedevere-bot commented May 16, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 3.9 has failed when building commit 98016f7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/250/builds/533) and take a look at the build logs.
  4. Check if the failure is related to this commit (98016f7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/250/builds/533

Failed tests:

  • test_gdb

Summary of the results of the build (if available):

==

Click to see traceback logs 
Note: switching to '98016f7c92aa4c1232c68bac1ed6646db31782ec'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 98016f7c92 [3.9] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (GH-102953) (#104382)
Switched to and reset branch '3.9'

configure: WARNING: unrecognized options: --without-static-libpython
configure: WARNING: unrecognized options: --without-static-libpython

../Modules/_threadmodule.c: In function ‘local_clear’:
../Modules/_threadmodule.c:812:20: warning: unused variable ‘tstate’ [-Wunused-variable]
     PyThreadState *tstate;
                    ^~~~~~

test_tk skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_msilib skipped -- No module named '_msi'
test_devpoll skipped -- test works only on Solaris OS family
test_startfile skipped -- object <module 'os' from '/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/build_oot/../Lib/os.py'> has no attribute 'startfile'
test_tix skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_flock (__main__.FNTLEINTRTest) ... ok
test_lockf (__main__.FNTLEINTRTest) ... ok
test_read (__main__.OSEINTRTest) ... ok
test_wait (__main__.OSEINTRTest) ... ok
test_wait3 (__main__.OSEINTRTest) ... ok
test_wait4 (__main__.OSEINTRTest) ... ok
test_waitpid (__main__.OSEINTRTest) ... ok
test_write (__main__.OSEINTRTest) ... ok
test_devpoll (__main__.SelectEINTRTest) ... skipped 'need select.devpoll'
test_epoll (__main__.SelectEINTRTest) ... ok
test_kqueue (__main__.SelectEINTRTest) ... skipped 'need select.kqueue'
test_poll (__main__.SelectEINTRTest) ... ok
test_select (__main__.SelectEINTRTest) ... ok
test_sigtimedwait (__main__.SignalEINTRTest) ... ok
test_sigwaitinfo (__main__.SignalEINTRTest) ... ok
test_accept (__main__.SocketEINTRTest) ... ok
test_open (__main__.SocketEINTRTest) ... ok
test_os_open (__main__.SocketEINTRTest) ... ok
test_recv (__main__.SocketEINTRTest) ... ok
test_recvmsg (__main__.SocketEINTRTest) ... ok
test_send (__main__.SocketEINTRTest) ... ok
test_sendall (__main__.SocketEINTRTest) ... ok
test_sendmsg (__main__.SocketEINTRTest) ... ok
test_sleep (__main__.TimeEINTRTest) ... ok

----------------------------------------------------------------------
Ran 24 tests in 8.221s

OK (skipped=2)
test_winconsoleio skipped -- test only relevant on win32
test_ttk_guionly skipped -- Tk unavailable due to TclError: no display name and no $DISPLAY environment variab [...]
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_winsound skipped -- No module named 'winsound'
test_winreg skipped -- No module named 'winreg'
<string>:2: PendingDeprecationWarning: lib2to3 package is deprecated and may not be able to parse Python 3.10+
test_ioctl skipped -- Unable to open /dev/tty
test_kqueue skipped -- test works only on BSD
Timeout (0:15:00)!
Thread 0x00007fff83965320 (most recent call first):
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/selectors.py", line 416 in select
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/subprocess.py", line 1995 in _communicate
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/subprocess.py", line 1134 in communicate
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 112 in run_gdb
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 226 in get_stack_trace
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 909 in test_pycfunction
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 550 in _callTestMethod
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 592 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 651 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/runner.py", line 184 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/support/__init__.py", line 1850 in _run_suite
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/support/__init__.py", line 1974 in run_unittest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 263 in _test_module
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 288 in _runtest_inner2
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 326 in _runtest_inner
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 204 in _runtest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 247 in runtest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest_mp.py", line 83 in run_tests_worker
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 692 in _main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 672 in main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 733 in main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/regrtest.py", line 43 in _main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/regrtest.py", line 47 in <module>
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/runpy.py", line 87 in _run_code
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/runpy.py", line 197 in _run_module_as_main
Timeout (0:15:00)!
Thread 0x00007fffa5a25320 (most recent call first):
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/selectors.py", line 416 in select
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/subprocess.py", line 1995 in _communicate
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/subprocess.py", line 1134 in communicate
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 112 in run_gdb
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 226 in get_stack_trace
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/test_gdb.py", line 909 in test_pycfunction
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 550 in _callTestMethod
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 592 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/case.py", line 651 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 122 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/suite.py", line 84 in __call__
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/unittest/runner.py", line 184 in run
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/support/__init__.py", line 1850 in _run_suite
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/support/__init__.py", line 1974 in run_unittest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 263 in _test_module
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 288 in _runtest_inner2
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 326 in _runtest_inner
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 217 in _runtest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/runtest.py", line 247 in runtest
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 334 in rerun_failed_tests
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 716 in _main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 672 in main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/libregrtest/main.py", line 733 in main
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/test/__main__.py", line 2 in <module>
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/runpy.py", line 87 in _run_code
  File "/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/Lib/runpy.py", line 197 in _run_module_as_main
make: *** [Makefile:1240: buildbottest] Error 1

Cannot open file '/home/buildbot/buildarea/3.9.cstratak-RHEL8-ppc64le/build/build_oot/test-results.xml' for upload

@encukou

encukou commented May 16, 2023

Copy link
Copy Markdown
Member Author

A test_gdb timeout looks unrelated. And the equivalent PR buildbot was green before merging.

@bedevere-bot

bedevere-bot commented May 16, 2023

Copy link
Copy Markdown

GH-104548 is a backport of this pull request to the 3.8 branch.

ambv pushed a commit that referenced this pull request May 17, 2023
@encukou
[3.8] gh-102950: Implement PEP 706 – Filter for tarfile.extractall (G… …
79e63e5 
…H-102953) (#104548)

Backport of c8c3956
@bedevere-bot

bedevere-bot commented May 17, 2023

Copy link
Copy Markdown

GH-104583 is a backport of this pull request to the 3.7 branch.

carlosroman added a commit to DataDog/cpython that referenced this pull request Jun 22, 2023
@carlosroman @ambv
@benjaminp @ned-deily @miss-islington @thunder-007 @gpshead @ucodery @hugovk @zooba @OTheDev @arhadthedev @corona10 @Blind4Basics @CAM-Gerlach @pradyunsg @encukou @samcarroll42 @ethanfurman @JelleZijlstra @gaogaotiantian @iritkatriel @stratakis @illia-v
Upgrade to 3.8.17 (#26) …
e0a363f 
* Post 3.8.16

* [3.8] Update copyright years to 2023. (pythongh-100852)

* [3.8] Update copyright years to 2023. (pythongh-100848).
(cherry picked from commit 11f9932)

Co-authored-by: Benjamin Peterson <benjamin@python.org>

* Update additional copyright years to 2023.

Co-authored-by: Ned Deily <nad@python.org>

* [3.8] Update copyright year in README (pythonGH-100863) (pythonGH-100867)

(cherry picked from commit 30a6cc4)

Co-authored-by: Ned Deily <nad@python.org>
Co-authored-by: HARSHA VARDHAN <75431678+Thunder-007@users.noreply.github.com>

* [3.8] Correct CVE-2020-10735 documentation (pythonGH-100306) (python#100698)

(cherry picked from commit 1cf3d78)
(cherry picked from commit 88fe8d7)

Co-authored-by: Jeremy Paige <ucodery@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>

* [3.8] Bump Azure Pipelines to ubuntu-22.04 (pythonGH-101089) (python#101215)

(cherry picked from commit c22a55c)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

* [3.8] pythongh-100180: Update Windows installer to OpenSSL 1.1.1s (pythonGH-100903) (python#101258)

* pythongh-101422: (docs) TarFile default errorlevel argument is 1, not 0 (pythonGH-101424)

(cherry picked from commit ea23271)

Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>

* [3.8] pythongh-95778: add doc missing in some places (pythonGH-100627) (python#101630)

(cherry picked from commit 4652182)

* [3.8] pythongh-101283: Improved fallback logic for subprocess with shell=True on Windows (pythonGH-101286) (python#101710)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>

* [3.8] pythongh-101981: Fix Ubuntu SSL tests with OpenSSL (3.1.0-beta1) CI i… (python#102095)

[3.8] pythongh-101981: Fix Ubuntu SSL tests with OpenSSL (3.1.0-beta1) CI issue (pythongh-102079)

* [3.8] pythonGH-102306 Avoid GHA CI macOS test_posix failure by using the appropriate macOS SDK (pythonGH-102307)

[3.8] Avoid GHA CI macOS test_posix failure by using the appropriate macOS SDK.

* [3.8] pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727) (pythonGH-101752)

Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Ned Deily <nad@python.org>

* [3.8] pythongh-102627: Replace address pointing toward malicious web page (pythonGH-102630) (pythonGH-102667)

(cherry picked from commit 61479d4)

Co-authored-by: Blind4Basics <32236948+Blind4Basics@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

* [3.8] pythongh-101997: Update bundled pip version to 23.0.1 (pythonGH-101998). (python#102244)

(cherry picked from commit 89d9ff0)

* [3.8] pythongh-102950: Implement PEP 706 – Filter for tarfile.extractall (pythonGH-102953) (python#104548)

Backport of c8c3956

* [3.8] pythongh-99889: Fix directory traversal security flaw in uu.decode() (pythonGH-104096) (python#104332)

(cherry picked from commit 0aeda29)

Co-authored-by: Sam Carroll <70000253+samcarroll42@users.noreply.github.com>

* [3.8] pythongh-104049: do not expose on-disk location from SimpleHTTPRequestHandler (pythonGH-104067) (python#104121)

Do not expose the local server's on-disk location from `SimpleHTTPRequestHandler` when generating a directory index. (unnecessary information disclosure)

(cherry picked from commit c7c3a60)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

* [3.8] pythongh-103935: Use `io.open_code()` when executing code in trace and profile modules (pythonGH-103947) (python#103954)

Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>

* [3.8] pythongh-68966: fix versionchanged in docs (pythonGH-105299)

* [3.8] Update GitHub CI workflow for macOS. (pythonGH-105302)

* [3.8] pythongh-105184: document that marshal functions can fail and need to be checked with PyErr_Occurred (pythonGH-105185) (python#105222)

(cherry picked from commit ee26ca1)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

* [3.8] pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508) (pythonGH-104575) (pythonGH-104592) (python#104593) (python#104895)

`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bit pythonGH-25595.

This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).

I simplified the docs by eliding the state of the world explanatory
paragraph in this security release only backport.  (people will see
that in the mainline /3/ docs)

(cherry picked from commit d7f8a5f)
(cherry picked from commit 2f630e1)
(cherry picked from commit 610cc0a)
(cherry picked from commit f48a96a)

Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>

* [3.8] pythongh-103142: Upgrade binary builds and CI to OpenSSL 1.1.1u (pythonGH-105174) (pythonGH-105200) (pythonGH-105205) (python#105370)

Upgrade builds to OpenSSL 1.1.1u.

Also updates _ssl_data_111.h from OpenSSL 1.1.1u, _ssl_data_300.h from 3.0.9.

Manual edits to the _ssl_data_300.h file prevent it from removing any
existing definitions in case those exist in some peoples builds and were
important (avoiding regressions during backporting).

(cherry picked from commit ede89af)
(cherry picked from commit e15de14)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Ned Deily <nad@python.org>

* Python 3.8.17

* Post 3.8.17

* Updated CI to build 3.8.17

---------

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Benjamin Peterson <benjamin@python.org>
Co-authored-by: Ned Deily <nad@python.org>
Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Co-authored-by: HARSHA VARDHAN <75431678+Thunder-007@users.noreply.github.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Jeremy Paige <ucodery@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Steve Dower <steve.dower@python.org>
Co-authored-by: Owain Davies <116417456+OTheDev@users.noreply.github.com>
Co-authored-by: Éric <earaujo@caravan.coop>
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Dong-hee Na <donghee.na@python.org>
Co-authored-by: Blind4Basics <32236948+Blind4Basics@users.noreply.github.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Sam Carroll <70000253+samcarroll42@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Co-authored-by: stratakis <cstratak@redhat.com>
Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
@CharlieZhao95 CharlieZhao95 mentioned this pull request Sep 4, 2023
Closed
@jwhitlock jwhitlock mentioned this pull request Oct 16, 2023
Merged
IlyasTalbi

This comment was marked as spam.

Sign in to view

@edgarrmondragon edgarrmondragon mentioned this pull request May 10, 2024
Closed
maxwell-k added a commit to maxwell-k/dotlocalslashbin that referenced this pull request Jul 16, 2024
@maxwell-k
Support Python 3.11.2 …
ba89cbc 
So that the script can be used on Debian 12.

> Changed in version 3.11.4: Added the filter parameter.

-- https://docs.python.org/3.11/library/tarfile.html

The implementation was in python/cpython#102953

Before this change, Debian 12 has Python 3.11.2, so this script errors
on a call with `filter=`

After this change the script does not error.
@maxwell-k maxwell-k mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead left review comments

@eryksun eryksun eryksun left review comments

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

+2 more reviewers

@hroncok hroncok

@IlyasTalbi IlyasTalbi IlyasTalbi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@encukou @bedevere-bot @hroncok @kulikjak @gpshead @eryksun @ethanfurman @IlyasTalbi