◐ Shell
reader mode source ↗
Skip to content

gh-103054: Improve Callable type subtitution tests#103055

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
sobolevn:issue-103054
Mar 29, 2023
Merged

gh-103054: Improve Callable type subtitution tests#103055
JelleZijlstra merged 2 commits into
python:mainfrom
sobolevn:issue-103054

Conversation

@sobolevn

@sobolevn sobolevn commented Mar 27, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 27, 2023
Closed
@sobolevn

sobolevn commented Mar 27, 2023

Copy link
Copy Markdown
Member Author

I understand why some people are afraid of typing 🙈

@AlexWaygood @Eclips4
Fix typo …
f94f6c9 
Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
@JelleZijlstra JelleZijlstra added the needs backport to 3.11 only security fixes label Mar 29, 2023
@JelleZijlstra JelleZijlstra merged commit 60bdc16 into python:main Mar 29, 2023
@miss-islington

miss-islington commented Mar 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Mar 29, 2023

Copy link
Copy Markdown

GH-103105 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 29, 2023
@sobolevn @AlexWaygood
@Eclips4 @miss-islington
pythongh-103054: typing: Improve Callable type substitution tests (p… …
8e06aa8 
…ythonGH-103055)

(cherry picked from commit 60bdc16)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 29, 2023
@miss-islington @sobolevn
@AlexWaygood @Eclips4
gh-103054: typing: Improve Callable type substitution tests (GH-103055 …
766038d 
)

(cherry picked from commit 60bdc16)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@sobolevn @AlexWaygood
@Eclips4 @warsaw
pythongh-103054: typing: Improve Callable type substitution tests (p… …
d067d26 
…ython#103055)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Eclips4 <80244920+Eclips4@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner

@AlexWaygood AlexWaygood AlexWaygood is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn @miss-islington @bedevere-bot @JelleZijlstra @Eclips4 @AlexWaygood