{{ message }}
gh-102978: Fix mock.patch function signatures for class and staticmethod decorators#103228
Merged
cjw296 merged 6 commits intoApr 13, 2023
Merged
gh-102978: Fix mock.patch function signatures for class and staticmethod decorators#103228cjw296 merged 6 commits into
cjw296 merged 6 commits into
Conversation
Member
Sorry, something went wrong.
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
sobolevn
reviewed
Apr 4, 2023
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
arhadthedev
added
the
stdlib
Standard Library Python modules in the Lib/ directory
label
Apr 4, 2023
tomasr8
force-pushed
the
gh-102978
branch
2 times, most recently
from
ab55da7 to
ade55ef
Compare
April 4, 2023 10:49
sobolevn
reviewed
Apr 4, 2023
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
Almost done, in my opinion :)
Sorry, something went wrong.
Member
Author
|
Thanks! I updated the tests |
Sorry, something went wrong.
sobolevn
reviewed
Apr 4, 2023
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
LGTM, but you will need an approve from the code owner :)
Sorry, something went wrong.
Member
Author
|
Awesome, thanks for your time! |
Sorry, something went wrong.
tomasr8
force-pushed
the
gh-102978
branch
2 times, most recently
from
a1b5a6b to
98f562e
Compare
April 4, 2023 22:04
Fixes unittest.mock.patch not enforcing function signatures for methods decorated with @classmethod or @staticmethod when patch is called with autospec=True.
cjw296
approved these changes
Apr 13, 2023
cjw296
left a comment
cjw296
left a comment
Contributor
There was a problem hiding this comment.
Really nice PR, thanks!
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 13, 2023
…ticmethod decorators (pythonGH-103228) Fixes unittest.mock.patch not enforcing function signatures for methods decorated with @classmethod or @staticmethod when patch is called with autospec=True. (cherry picked from commit 59e0de4) Co-authored-by: Tomas R <tomas.roun8@gmail.com>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Apr 13, 2023
* main: pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495) pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494) pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502) pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500) pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507) pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228) pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463) pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
…ticmethod decorators (python#103228) Fixes unittest.mock.patch not enforcing function signatures for methods decorated with @classmethod or @staticmethod when patch is called with autospec=True.
ambv
pushed a commit
that referenced
this pull request
May 22, 2023
…aticmethod decorators (GH-103228) (#103499) Fixes unittest.mock.patch not enforcing function signatures for methods decorated with @classmethod or @staticmethod when patch is called with autospec=True. (cherry picked from commit 59e0de4) Co-authored-by: Tomas R <tomas.roun8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Closes #102978
As reported in the original issue,
unittest.mock.patchdoes not correctly extract function signatures from methods decorated with@classmethodand@staticmethodwhenpatchis called withautospec=True.This fix adds a special case to the extraction logic which uses the original decorated function via
__func__to get the correct signature.I also updated the relevant tests.