◐ Shell
reader mode source ↗
Skip to content

gh-102799: use sys.exception() instead of sys.exc_info() in tests#103293

Merged
iritkatriel merged 9 commits into
python:mainfrom
iritkatriel:exc_info
Apr 6, 2023
Merged

gh-102799: use sys.exception() instead of sys.exc_info() in tests#103293
iritkatriel merged 9 commits into
python:mainfrom
iritkatriel:exc_info

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Apr 5, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Now that 3.10 is no longer getting bugfixes, we can use sys.exception() without worrying about it impacting bugfix backports (it exists since 3.11).

This PR does the tests.

@bedevere-bot bedevere-bot mentioned this pull request Apr 5, 2023
Closed
@iritkatriel iritkatriel added skip news tests Tests in the Lib/test dir labels Apr 5, 2023
gvanrossum
gvanrossum approved these changes Apr 6, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

One nit, no need to wait for another approval after you fix it.

@iritkatriel iritkatriel merged commit 482b6ee into python:main Apr 6, 2023
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@iritkatriel @warsaw
pythongh-102799: use sys.exception() instead of sys.exc_info() in tes… …
0888a42 
…ts (python#103293)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees

No one assigned

Labels

skip news Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iritkatriel @gvanrossum @bedevere-bot