gh-95299: Rework test_cppext.py to not invoke setup.py directly#103316
gh-95299: Rework test_cppext.py to not invoke setup.py directly#103316pradyunsg merged 7 commits into
Conversation
Sorry, something went wrong.
|
!buildbot (?i).installed. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @zware for commit 635492e 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
|
Hmm... I didn't intend for the reverts to make it into the PR, but oh well, they're here now. 😅 The main change is that it's no longer moving the files around, and instead using the temporary directory created for the build within the outer-caller of the test; this serves as a temporary directory for the package to be built and installed via a regular |
Sorry, something went wrong.
|
!buildbot (?i).installed. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @pradyunsg for commit f6c4024 🤖 The command will test the builders whose names match following regular expression: The builders matched are: |
Sorry, something went wrong.
|
!buildbot (?i).installed. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @pradyunsg for commit f6c4024 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
|
Just to cross reference for others' benefit, previous buildbot discussion: #101039 (comment) |
Sorry, something went wrong.
|
!buildbot (?i).installed. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @pradyunsg for commit dd16041 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
FFY00
left a comment
FFY00
left a comment
There was a problem hiding this comment.
I think ideally we'd want to get rid of setuptools entirely here, but this is a reasonable solution while that doesn't happen (it's not trivial to implement). The implementation itself looks good to me, so you have my 👍.
Sorry, something went wrong.
* main: pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495) pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494) pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502) pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500) pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507) pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228) pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463) pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
…python#103316) * pythongh-95299: Rework test_cppext.py to not invoke setup.py directly * Add tests/cppextdata data to `TESTSUBDIRS` * Revert "Add tests/cppextdata data to `TESTSUBDIRS`" This reverts commit 635492e. * Revert "pythongh-95299: Rework test_cppext.py to not invoke setup.py directly" This reverts commit 41c5a66. * Build and install the extension in a temporary directory instead * Pull in wheels for setuptools and wheel for testing extension builds
Pulling these changes out of #101039, as requested by @vstinner. :)