◐ Shell
reader mode source ↗
Skip to content

gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending#103463

Merged
kumaraditya303 merged 7 commits into
python:mainfrom
alisaifee:fix-incomplete-writeline
Apr 13, 2023
Merged

gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending#103463
kumaraditya303 merged 7 commits into
python:mainfrom
alisaifee:fix-incomplete-writeline

Conversation

@alisaifee

@alisaifee alisaifee commented Apr 12, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

When the payload used with SelectorSocketTransport.writelines is too large to write in one call to either socket.send or socket.sendmsg the remaining buffer needs to be handled by registering a write handler.

Related Pull Request / Issue

@alisaifee
Add explicit tests for writelines …
273e1e7 
Includes two failing tests that demonstrate a bug
where if the data passed to writelines can't be sent
in one shot, the remaining buffer isn't written since
there is no registered write handler
@alisaifee
Schedule writer for remaining buffer in writelines …
ce03f17 
If all the data in the buffer can't be written immediately
schedule a writer to handle the remaining data.
@bedevere-bot

bedevere-bot commented Apr 12, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot mentioned this pull request Apr 12, 2023
Closed
@ghost

ghost commented Apr 12, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

bedevere-bot commented Apr 12, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@alisaifee alisaifee changed the title gh-103462: Ensure SelectorSocketTransport.writelines schedules a writer when data is still pending Apr 12, 2023
@alisaifee
Ensure tests using sendmsg are marked with skip …
c5a071e 
When the platform (windows) doesn't support it
skip tests for writelines using sendmsg
@bedevere-bot

bedevere-bot commented Apr 12, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

kumaraditya303
kumaraditya303 reviewed Apr 12, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, Can you add a news entry? Thanks

@alisaifee

alisaifee commented Apr 12, 2023

Copy link
Copy Markdown
Contributor Author

LGTM, Can you add a news entry? Thanks

done!

@kumaraditya303 kumaraditya303 linked an issue Apr 13, 2023 that may be closed by this pull request
Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket #103462
Closed
@kumaraditya303 kumaraditya303 merged commit 19d2639 into python:main Apr 13, 2023
carljm added a commit to carljm/cpython that referenced this pull request Apr 13, 2023
@carljm
Merge branch 'main' into superopt …
9384106 
* main:
  pythongh-103479: [Enum] require __new__ to be considered a data type (pythonGH-103495)
  pythongh-103365: [Enum] STRICT boundary corrections (pythonGH-103494)
  pythonGH-103488: Use return-offset, not yield-offset. (pythonGH-103502)
  pythongh-103088: Fix test_venv error message to avoid bytes/str warning (pythonGH-103500)
  pythonGH-103082: Turn on branch events for FOR_ITER instructions. (python#103507)
  pythongh-102978: Fix mock.patch function signatures for class and staticmethod decorators (python#103228)
  pythongh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending (python#103463)
  pythongh-95299: Rework test_cppext.py to not invoke setup.py directly (python#103316)
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@alisaifee @aisk
pythongh-103462: Ensure SelectorSocketTransport.writelines registers … …
44b69f6 
…a writer when data is still pending (python#103463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket

3 participants

@alisaifee @bedevere-bot @kumaraditya303