◐ Shell
reader mode source ↗
Skip to content

gh-103592: Add tests of Literal with Enum and Union of Literals#103706

Merged
AlexWaygood merged 1 commit into
python:mainfrom
sobolevn:issue-103592
Apr 23, 2023
Merged

gh-103592: Add tests of Literal with Enum and Union of Literals#103706
AlexWaygood merged 1 commit into
python:mainfrom
sobolevn:issue-103592

Conversation

@sobolevn

@sobolevn sobolevn commented Apr 23, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

These tests should catch theoretical future regressions similar to ones described in #103592

@bedevere-bot bedevere-bot mentioned this pull request Apr 23, 2023
Closed
@JelleZijlstra JelleZijlstra added the needs backport to 3.11 only security fixes label Apr 23, 2023
@AlexWaygood AlexWaygood merged commit 5041c2b into python:main Apr 23, 2023
@miss-islington

miss-islington commented Apr 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 23, 2023
@sobolevn @miss-islington
pythongh-103592: Add tests of Literal with Enum and Union of `L… …
14db874 
…iteral`s (pythonGH-103706)

(cherry picked from commit 5041c2b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Apr 23, 2023

Copy link
Copy Markdown

GH-103720 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 23, 2023
@AlexWaygood

AlexWaygood commented Apr 23, 2023

Copy link
Copy Markdown
Member

@sobolevn, are you up for backporting these tests to typing_extensions as well?

AlexWaygood pushed a commit that referenced this pull request Apr 23, 2023
@miss-islington @sobolevn
[3.11] gh-103592: Add tests of Literal with Enum and Union of `… …
4e9635e 
…Literal`s (GH-103706) (#103720)

gh-103592: Add tests of `Literal` with `Enum` and `Union` of `Literal`s (GH-103706)
(cherry picked from commit 5041c2b)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn

sobolevn commented Apr 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Now I realized that I've missed | unions in this PR. Can I please add one more PR with an extra test to test_types?

@AlexWaygood Yeah, sure. Will do tomorrow.

This was referenced Apr 24, 2023
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @miss-islington @bedevere-bot @AlexWaygood @JelleZijlstra