◐ Shell
reader mode source ↗
Skip to content

GH-103899: Provide a hint when accidentally calling a module#103900

Merged
brandtbucher merged 6 commits into
python:mainfrom
brandtbucher:typeerror-module-hint
May 4, 2023
Merged

GH-103899: Provide a hint when accidentally calling a module#103900
brandtbucher merged 6 commits into
python:mainfrom
brandtbucher:typeerror-module-hint

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Apr 26, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@brandtbucher brandtbucher added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 26, 2023
@brandtbucher brandtbucher self-assigned this Apr 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 26, 2023
Closed
@JelleZijlstra

JelleZijlstra commented May 4, 2023

Copy link
Copy Markdown
Member

@brandtbucher any reason not to merge this? Would be great to get it into 3.12. I'd merge it myself but maybe you have some reason to hold off.

@brandtbucher

brandtbucher commented May 4, 2023

Copy link
Copy Markdown
Member Author

Yep, it just fell off my radar. If anybody thinks the logic should be cleaned up, then that can be considered in another PR.

@brandtbucher brandtbucher merged commit 7d35c31 into python:main May 4, 2023
carljm added a commit to carljm/cpython that referenced this pull request May 5, 2023
@carljm
Merge branch 'main' into inlinecomp2 …
8a78a36 
* main: (61 commits)
  pythongh-64595: Argument Clinic: Touch source file if any output file changed (python#104152)
  pythongh-64631: Test exception messages in cloned Argument Clinic funcs (python#104167)
  pythongh-68395: Avoid naming conflicts by mangling variable names in Argument Clinic (python#104065)
  pythongh-64658: Expand Argument Clinic return converter docs (python#104175)
  pythonGH-103092: port `_asyncio` freelist to module state (python#104196)
  pythongh-104051: fix crash in test_xxtestfuzz with -We (python#104052)
  pythongh-104190: fix ubsan crash (python#104191)
  pythongh-104106: Add gcc fallback of mkfifoat/mknodat for macOS (pythongh-104129)
  pythonGH-104142: Fix _Py_RefcntAdd to respect immortality (pythonGH-104143)
  pythongh-104112: link from cached_property docs to method-caching FAQ (python#104113)
  pythongh-68968: Correcting message display issue with assertEqual (python#103937)
  pythonGH-103899: Provide a hint when accidentally calling a module (pythonGH-103900)
  pythongh-103963: fix 'make regen-opcode' in out-of-tree builds (python#104177)
  pythongh-102500: Add PEP 688 and 698 to the 3.12 release highlights (python#104174)
  pythonGH-81079: Add case_sensitive argument to `pathlib.Path.glob()` (pythonGH-102710)
  pythongh-91896: Deprecate collections.abc.ByteString (python#102096)
  pythongh-99593: Add tests for Unicode C API (part 2) (python#99868)
  pythongh-102500: Document PEP 688 (python#102571)
  pythongh-102500: Implement PEP 688 (python#102521)
  pythongh-96534: socketmodule: support FreeBSD divert(4) socket (python#96536)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gaogaotiantian gaogaotiantian gaogaotiantian left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) sprint type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandtbucher @JelleZijlstra @gaogaotiantian @bedevere-bot