◐ Shell
reader mode source ↗
Skip to content

gh-103092: Adapt _ctypes's PyCStgDict type to heap type#103932

Closed
erlend-aasland wants to merge 3 commits into
python:mainfrom
erlend-aasland:isolate-ctypes/part2-take2
Closed

gh-103092: Adapt _ctypes's PyCStgDict type to heap type#103932
erlend-aasland wants to merge 3 commits into
python:mainfrom
erlend-aasland:isolate-ctypes/part2-take2

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 27, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Port PyCStgDict_Type to heap type.

@bedevere-bot bedevere-bot mentioned this pull request Apr 27, 2023
Closed
25 tasks
@erlend-aasland

erlend-aasland commented Apr 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This probably fails because of the dict hacks in StructUnionType_new (wild guess).

@corona10 corona10 self-requested a review April 27, 2023 23:31
@kumaraditya303 kumaraditya303 force-pushed the isolate-ctypes/part2-take2 branch from 11c91c9 to 56fd7e9 Compare May 15, 2023 09:49
@kumaraditya303

kumaraditya303 commented May 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

While I am still trying to figure out where it breaks, you may proceed to port other simpler types (if there are any).

@vstinner

vstinner commented Jul 12, 2023

Copy link
Copy Markdown
Member

What's the status of this PR? Is it ready for review? It's still marked as a draft.

@erlend-aasland erlend-aasland changed the title gh-103092: Isolate _ctypes, part 2 Jan 9, 2024
@erlend-aasland erlend-aasland changed the title gh-103092: Adapt _ctypes.PyCStgDict_Type to heap type Jan 9, 2024
@erlend-aasland

erlend-aasland commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

I don't have the bandwidth to follow up this right now; abandoning this PR.

@erlend-aasland erlend-aasland deleted the isolate-ctypes/part2-take2 branch January 9, 2024 21:47
@vstinner vstinner mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

@corona10 corona10 Awaiting requested review from corona10

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

1 more reviewer

@neonene neonene neonene left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @kumaraditya303 @vstinner @neonene @bedevere-bot