◐ Shell
reader mode source ↗
Skip to content

Clickable Email in the "About" Window#104045

Closed
CJYKK wants to merge 2 commits into
python:mainfrom
CJYKK:CJYKK-patch-1
Closed

Clickable Email in the "About" Window#104045
CJYKK wants to merge 2 commits into
python:mainfrom
CJYKK:CJYKK-patch-1

Conversation

@CJYKK

@CJYKK CJYKK commented May 1, 2023

Copy link
Copy Markdown

Make email address clickable in the "About" window (using "mailto").
If you click it, it will automatically use your default email client and set the recipient to "idle-dev@python.org".

@CJYKK
Clickable Email …
756dbb0 
Make email address clickable in the "About" window (using "mailto:<address>").
@CJYKK CJYKK requested a review from terryjreedy as a code owner May 1, 2023 15:26
@ghost

ghost commented May 1, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

bedevere-bot commented May 1, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@CJYKK

CJYKK commented May 1, 2023

Copy link
Copy Markdown
Author

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Uhhh...
I can't add NEWS because the web app tells me I need to fill in the issue number, but I don't have it...

@terryjreedy

terryjreedy commented May 1, 2023

Copy link
Copy Markdown
Member

A good idea but I have been thinking about changing that to suggest discuss.python.org instead.

@CJYKK

CJYKK commented May 5, 2023

Copy link
Copy Markdown
Author

A good idea but I have been thinking about changing that to suggest discuss.python.org instead.

I'd like to do that, but... How do I do it?

@CJYKK @arhadthedev
Update Lib/idlelib/help_about.py …
28420fd 
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@CJYKK

CJYKK commented May 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Author

Oh, I know now...
Since I'm not a native English speaker, So I didn't understand the changes you requested before. Sorry... 😥

@terryjreedy

terryjreedy commented May 6, 2023

Copy link
Copy Markdown
Member

I need to discuss the idea and details with other core developers before doing anything.

@terryjreedy

terryjreedy commented Feb 8, 2025

Copy link
Copy Markdown
Member

Thank you for the contribution, but it is now obsolete. The email address was changed to a clickable link to discuss.python.org in PR #122482. The ability to click is not obvious so the link is being made a button in #129591.

@terryjreedy terryjreedy closed this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@terryjreedy terryjreedy terryjreedy is a code owner

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE skip issue skip news topic-IDLE

Projects

IDLE Issues
Status: Done +1 more

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CJYKK @bedevere-bot @terryjreedy @arhadthedev