◐ Shell
reader mode source ↗
Skip to content

gh-101819: Adapt _io.PyWindowsConsoleIO_Type to heap type#104197

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:isolate-io/winconsoleio
May 7, 2023
Merged

gh-101819: Adapt _io.PyWindowsConsoleIO_Type to heap type#104197
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:isolate-io/winconsoleio

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 5, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot mentioned this pull request May 5, 2023
Closed
@erlend-aasland erlend-aasland requested review from ericsnowcurrently, kumaraditya303 and vstinner and removed request for ericsnowcurrently May 5, 2023 11:23
@vstinner

vstinner commented May 6, 2023

Copy link
Copy Markdown
Member

Is it a draft or ready for review?

@vstinner

vstinner commented May 6, 2023

Copy link
Copy Markdown
Member 
FAIL: test_no_memleak (test.test_embed.MiscTests.test_no_memleak) (frozen_modules='on', stmt='import __hello__')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_embed.py", line 1802, in test_no_memleak
    self.assertEqual(refs, 0, out)
AssertionError: 512 != 0 : [512 refs, 302 blocks]

It seems like there is leak somewhere.

@vstinner

vstinner commented May 6, 2023

Copy link
Copy Markdown
Member 
test_winconsoleio crashed (Exit code 3) -- running: test_multiprocessing_spawn (2 min 47 sec)
A�s�s�e�r�t�i�o�n� �f�a�i�l�e�d�:� �P�y�O�b�j�e�c�t�_�T�y�p�e�C�h�e�c�k�(�s�e�l�f�,� �(�P�y�T�y�p�e�O�b�j�e�c�t� �*�)�&�P�y�W�i�n�d�o�w�s�C�o�n�s�o�l�e�I�O�_�T�y�p�e�)�,� �f�i�l�e� �D�:�\�a�\�c�p�y�t�h�o�n�\�c�p�y�t�h�o�n�\�M�o�d�u�l�e�s�\�_�i�o�\�w�i�n�c�o�n�s�o�l�e�i�o�.�c�,� �l�i�n�e� �2�6�8�
�Fatal Python error: Aborted

There are still some test failures. Tell me if you need my help to debug that next week.

@erlend-aasland

erlend-aasland commented May 6, 2023

Copy link
Copy Markdown
Contributor Author

Is it a draft or ready for review?

Draft! I don't have a Windows dev environment set up, so I rely on the CI for these changes.

@erlend-aasland erlend-aasland marked this pull request as ready for review May 6, 2023 21:42
@python python deleted a comment from bedevere-bot May 6, 2023
@python python deleted a comment from bedevere-bot May 6, 2023
@python python deleted a comment from bedevere-bot May 6, 2023
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 6, 2023
@bedevere-bot

bedevere-bot commented May 6, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 7c9065f 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 6, 2023
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 6, 2023
@bedevere-bot

bedevere-bot commented May 6, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit cf81d43 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 6, 2023
@erlend-aasland

erlend-aasland commented May 7, 2023

Copy link
Copy Markdown
Contributor Author

Why isn't the Windows ref leaks bots part of the refleak portion of the fleet?

@erlend-aasland erlend-aasland merged commit cab1298 into python:main May 7, 2023
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@erlend-aasland @jbower-fb
pythongh-101819: Adapt _io.PyWindowsConsoleIO_Type to heap type (pyth… …
e63898e 
…on#104197)
vstinner
vstinner reviewed May 9, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Review after merge: LGTM, but the #ifdef around assert() is wrong IMO.

@erlend-aasland erlend-aasland deleted the isolate-io/winconsoleio branch May 9, 2023 22:17
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 10, 2023
@erlend-aasland
Address Victor's review of pythongh-104197
725e784
erlend-aasland added a commit that referenced this pull request May 10, 2023
@erlend-aasland
gh-101819: Clean up _io windows console io after gh-104197 (#104354)
2dcb289
carljm added a commit to carljm/cpython that referenced this pull request May 10, 2023
@carljm
Merge branch 'main' into fixloadsuperspec …
5976df9 
* main:
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  pythongh-103247: clear the module cache in a test in test_importlib/extensions/test_loader.py (pythonGH-104226)
  pythongh-103848: Adds checks to ensure that bracketed hosts found by urlsplit are of IPv6 or IPvFuture format (python#103849)
  pythongh-74895: adjust tests to work on Solaris (python#104326)
  pythongh-101819: Refactor _io in preparation for module isolation (python#104334)
  pythongh-90953: Don't use deprecated AST nodes in clinic.py (python#104322)
  pythongh-102327: Extend docs for "url" and "headers" parameters to HTTPConnection.request()
  pythongh-104328: Fix typo in ``typing.Generic`` multiple inheritance error message (python#104335)
carljm added a commit to carljm/cpython that referenced this pull request May 11, 2023
@carljm
Merge branch 'main' into supermon …
19b3d9e 
* main: (27 commits)
  pythongh-87849: fix SEND specialization family definition (pythonGH-104268)
  pythongh-101819: Adapt _io.IOBase.seek and _io.IOBase.truncate to Argument Clinic (python#104384)
  pythongh-101819: Adapt _io._Buffered* methods to Argument Clinic (python#104367)
  pythongh-101819: Refactor `_io` futher in preparation for module isolation (python#104369)
  pythongh-101819: Adapt _io.TextIOBase methods to Argument Clinic (python#104383)
  pythongh-101117: Improve accuracy of sqlite3.Cursor.rowcount docs (python#104287)
  pythonGH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects (python#92185)
  pythongh-104357: fix inlined comprehensions that close over iteration var (python#104368)
  pythonGH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` (pythonGH-104141)
  pythonGH-102181: Improve specialization stats for SEND (pythonGH-102182)
  pythongh-103000: Optimise `dataclasses.asdict` for the common case (python#104364)
  pythongh-103538: Remove unused TK_AQUA code (pythonGH-103539)
  pythonGH-87695: Fix OSError from `pathlib.Path.glob()` (pythonGH-104292)
  pythongh-104263: Rely on Py_NAN and introduce Py_INFINITY (pythonGH-104202)
  pythongh-104010: Separate and improve docs for `typing.get_origin` and `typing.get_args` (python#104013)
  pythongh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic (python#104355)
  pythongh-103960: Dark mode: invert image brightness (python#103983)
  pythongh-104252: Immortalize Py_EMPTY_KEYS (pythongh-104253)
  pythongh-101819: Clean up _io windows console io after pythongh-104197 (python#104354)
  pythongh-101819: Harden _io init (python#104352)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @vstinner @bedevere-bot @kumaraditya303