◐ Shell
reader mode source ↗
Skip to content

gh-101819: Prepare _io._IOBase for module state#104386

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:isolate-io/prepare-iobase
May 12, 2023
Merged

gh-101819: Prepare _io._IOBase for module state#104386
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:isolate-io/prepare-iobase

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 11, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • Add PyIOBase_Type to _io module state
  • Pass defining class to _io._IOBase.fileno

@erlend-aasland
pythongh-101819: Prepare _io._IOBase for module state …
3d782e9 
- Add PyIOBase_Type to _io module state
- Pass defining class to _io._IOBase.fileno
@bedevere-bot bedevere-bot mentioned this pull request May 11, 2023
Closed
corona10
corona10 approved these changes May 11, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

lgtm

@bedevere-bot bedevere-bot added awaiting merge and removed labels May 11, 2023
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 11, 2023
@bedevere-bot

bedevere-bot commented May 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 3d782e9 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 11, 2023
@erlend-aasland

erlend-aasland commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Dong-hee! Let's run the bots, since we're touching the visit and free funcs.

@erlend-aasland

erlend-aasland commented May 12, 2023

Copy link
Copy Markdown
Contributor Author

I wonder why the s390x refleak bots are failing. Is there an issue on main?

@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 12, 2023
@bedevere-bot

bedevere-bot commented May 12, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit e436471 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 12, 2023
@kumaraditya303

kumaraditya303 commented May 12, 2023

Copy link
Copy Markdown
Contributor

I wonder why the s390x refleak bots are failing. Is there an issue on main?

#104413

@kumaraditya303 kumaraditya303 self-assigned this May 12, 2023
@erlend-aasland erlend-aasland enabled auto-merge (squash) May 12, 2023 07:18
@erlend-aasland erlend-aasland merged commit 15795b5 into python:main May 12, 2023
@kumaraditya303 kumaraditya303 deleted the isolate-io/prepare-iobase branch May 12, 2023 07:31
carljm added a commit to carljm/cpython that referenced this pull request May 12, 2023
@carljm
Merge branch 'main' into supermon …
8efd7c6 
* main:
  pythongh-91896: Fixup some docs issues following ByteString deprecation (python#104422)
  pythonGH-104371: check return value of calling `mv.release` (python#104417)
  pythongh-104415: Fix refleak tests for `typing.ByteString` deprecation (python#104416)
  pythonGH-86275: Implementation of hypothesis stubs for property-based tests, with zoneinfo tests (python#22863)
  pythonGH-103082: Filter LINE events in VM, to simplify tool implementation. (pythonGH-104387)
  pythongh-93649: Split gc- and allocation tests from _testcapimodule.c (pythonGH-104403)
  pythongh-104389: Add 'unused' keyword to Argument Clinic C converters (python#104390)
  pythongh-101819: Prepare _io._IOBase for module state (python#104386)
  pythongh-104413: Fix refleak when super attribute throws AttributeError (python#104414)
  Fix refleak in `super_descr_get` (python#104408)
  pythongh-87526: Remove dead initialization from _zoneinfo parse_abbr() (python#24700)
  pythongh-91896: Improve visibility of `ByteString` deprecation warnings (python#104294)
  pythongh-104371: Fix calls to `__release_buffer__` while an exception is active (python#104378)
  pythongh-104377: fix cell in comprehension that is free in outer scope (python#104394)
  pythongh-104392: Remove _paramspec_tvars from typing (python#104393)
  pythongh-104396: uuid.py to skip platform check for emscripten and wasi (pythongh-104397)
  pythongh-99108: Refresh HACL* from upstream (python#104401)
  pythongh-104301: Allow leading whitespace in disambiguated pdb statements (python#104342)
@JelleZijlstra JelleZijlstra mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

@kumaraditya303 kumaraditya303

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @bedevere-bot @kumaraditya303 @corona10