bpo-35208: Fix IDLE Squeezer line counting#10449
Conversation
73e0fea to
675b42f
Compare
November 10, 2018 21:19
675b42f to
01fa746
Compare
November 10, 2018 21:45
|
@terryjreedy, this is a bugfix and I really think it should go into 3.6 before it's too late. Would you like to review this or can I just merge it? |
Sorry, something went wrong.
|
It is semi too late in that the rcs are already out. We would have to commit to 3.8 and 3.7.2+ and request cherry-pick to the two release branches. However, the plural issue is not critical, and as I said on issue, I don't necessarily consider reporting logical lines to be a bug. If I have misunderstood the issue, please clarify. |
Sorry, something went wrong.
|
Example: |
Sorry, something went wrong.
|
At the moment, I cannot make any changes, or even make an inline comment. Same as for #11214. |
Sorry, something went wrong.
All tests continue to pass.
Tests continue to pass.
terryjreedy
left a comment
There was a problem hiding this comment.
I added news items and made a couple of changes. If you are happy with them, go ahead and merge.
Sorry, something went wrong.
|
@terryjreedy, thanks for the review and improvements! I have a few comments, let me know what you think. |
Sorry, something went wrong.
|
Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Sorry, something went wrong.
(cherry picked from commit 44a79cc) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
This also fixes the label when squeezing a single line to "Squeezed text (1 line)", rather than "Squeezed text (1 lines)".
https://bugs.python.org/issue35208