◐ Shell
reader mode source ↗
Skip to content

gh-104050: Add typing to Argument Clinic converters#104547

Merged
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:typed-clinic/converters
May 16, 2023
Merged

gh-104050: Add typing to Argument Clinic converters#104547
erlend-aasland merged 6 commits into
python:mainfrom
erlend-aasland:typed-clinic/converters

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 16, 2023 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot mentioned this pull request May 16, 2023
Closed
AlexWaygood
AlexWaygood approved these changes May 16, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good.

Doesn't need to be done in this PR, but most of the accept parameters could be annotated with set[bltns.type[Any]]. You could create an alias for that annotation somewhere, to make it less repetitive, and then add that alias as an annotation to those parameters

@erlend-aasland

erlend-aasland commented May 16, 2023

Copy link
Copy Markdown
Contributor Author

Looks good.

Doesn't need to be done in this PR, but most of the accept parameters could be annotated with set[bltns.type[Any]]. You could create an alias for that annotation somewhere, to make it less repetitive, and then add that alias as an annotation to those parameters

Let's save that for the next PR.

@erlend-aasland erlend-aasland enabled auto-merge (squash) May 16, 2023 22:28
@erlend-aasland erlend-aasland merged commit 0afc473 into python:main May 16, 2023
@erlend-aasland erlend-aasland deleted the typed-clinic/converters branch May 16, 2023 22:42
@bedevere-bot

bedevere-bot commented May 16, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 0afc473.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/3962) and take a look at the build logs.
  4. Check if the failure is related to this commit (0afc473) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/3962

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

442 tests OK.

10 slowest tests:

  • test_largefile: 6 min 32 sec
  • test_venv: 4 min 53 sec
  • test_multiprocessing_spawn: 4 min 30 sec
  • test_math: 4 min 28 sec
  • test_concurrent_futures: 4 min 18 sec
  • test_shelve: 4 min 6 sec
  • test_multiprocessing_main_handling: 2 min 19 sec
  • test_tokenize: 2 min 14 sec
  • test_hashlib: 2 min 11 sec
  • test_cppext: 1 min 59 sec

1 test altered the execution environment:
test_concurrent_futures

22 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_idle
test_ioctl test_kqueue test_launcher test_msilib
test_peg_generator test_perf_profiler test_startfile test_tcl
test_tix test_tkinter test_ttk test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

Total duration: 33 min 1 sec

Click to see traceback logs 
remote: Enumerating objects: 5, done.        
remote: Counting objects:  20% (1/5)        
remote: Counting objects:  40% (2/5)        
remote: Counting objects:  60% (3/5)        
remote: Counting objects:  80% (4/5)        
remote: Counting objects: 100% (5/5)        
remote: Counting objects: 100% (5/5), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 5 (delta 0), reused 3 (delta 0), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '0afc473f500955b85c71725d8ae7d65787db5dd1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 0afc473f50 gh-104050: Add typing to Argument Clinic converters (#104547)
Switched to and reset branch 'main'

./Modules/_testcapi/heaptype_relative.c: In function ‘make_sized_heaptypes’:
./Modules/_testcapi/heaptype_relative.c:62:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   62 |                            (unsigned long long)data_ptr,
      |                            ^

make: *** [Makefile:1976: buildbottest] Error 3

carljm added a commit to carljm/cpython that referenced this pull request May 17, 2023
@carljm
Merge branch 'main' into 709funconly …
b1bb3a7 
* main: (26 commits)
  pythonGH-101520: Move tracemalloc functionality into core, leaving interface in Modules. (python#104508)
  typing: Add more tests for TypeVar (python#104571)
  pythongh-104572: Improve error messages for invalid constructs in PEP 695 contexts (python#104573)
  typing: Use PEP 695 syntax in typing.py (python#104553)
  pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (python#102508)
  pythongh-104469: Update README.txt for _testcapi (pythongh-104529)
  pythonGH-103092: isolate `_elementtree` (python#104561)
  pythongh-104050: Add typing to Argument Clinic converters (python#104547)
  pythonGH-103906: Remove immortal refcounting in the interpreter (pythonGH-103909)
  pythongh-87474: Fix file descriptor leaks in subprocess.Popen (python#96351)
  pythonGH-103092: isolate `pyexpat`  (python#104506)
  pythongh-75367: Fix data descriptor detection in inspect.getattr_static (python#104517)
  pythongh-104050: Add more annotations to `Tools/clinic.py` (python#104544)
  pythongh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 (python#104556)
  pythongh-103865: add monitoring support to LOAD_SUPER_ATTR (python#103866)
  CODEOWNERS: Assign new PEP 695 files to myself (python#104551)
  pythonGH-104510: Fix refleaks in `_io` base types (python#104516)
  pythongh-104539: Fix indentation error in logging.config.rst (python#104545)
  pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)
  pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@AlexWaygood AlexWaygood

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @bedevere-bot @AlexWaygood @Eclips4