{{ message }}
typing: Use PEP 695 syntax in typing.py#104553
Merged
JelleZijlstra merged 5 commits intoMay 17, 2023
Merged
Conversation
Member
Sorry, something went wrong.
JelleZijlstra
requested review from
AlexWaygood,
Fidget-Spinner and
gvanrossum
as code owners
May 16, 2023 14:38
JelleZijlstra
commented
May 16, 2023
AlexWaygood
reviewed
May 16, 2023
AlexWaygood
reviewed
May 16, 2023
AlexWaygood
reviewed
May 16, 2023
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
The test_typing failures look concerning!
Sorry, something went wrong.
Member
I filed: |
Sorry, something went wrong.
gvanrossum
reviewed
May 16, 2023
AlexWaygood
reviewed
May 16, 2023
gvanrossum
approved these changes
May 16, 2023
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
I don't care what you do with dataclass_transform -- either approach is fine with me. So, LGTM and don't wait for me.
Sorry, something went wrong.
AlexWaygood
approved these changes
May 17, 2023
carljm
added a commit
to carljm/cpython
that referenced
this pull request
May 17, 2023
* main: (26 commits) pythonGH-101520: Move tracemalloc functionality into core, leaving interface in Modules. (python#104508) typing: Add more tests for TypeVar (python#104571) pythongh-104572: Improve error messages for invalid constructs in PEP 695 contexts (python#104573) typing: Use PEP 695 syntax in typing.py (python#104553) pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (python#102508) pythongh-104469: Update README.txt for _testcapi (pythongh-104529) pythonGH-103092: isolate `_elementtree` (python#104561) pythongh-104050: Add typing to Argument Clinic converters (python#104547) pythonGH-103906: Remove immortal refcounting in the interpreter (pythonGH-103909) pythongh-87474: Fix file descriptor leaks in subprocess.Popen (python#96351) pythonGH-103092: isolate `pyexpat` (python#104506) pythongh-75367: Fix data descriptor detection in inspect.getattr_static (python#104517) pythongh-104050: Add more annotations to `Tools/clinic.py` (python#104544) pythongh-104555: Fix isinstance() and issubclass() for runtime-checkable protocols that use PEP 695 (python#104556) pythongh-103865: add monitoring support to LOAD_SUPER_ATTR (python#103866) CODEOWNERS: Assign new PEP 695 files to myself (python#104551) pythonGH-104510: Fix refleaks in `_io` base types (python#104516) pythongh-104539: Fix indentation error in logging.config.rst (python#104545) pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543) pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538) ...
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
May 18, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
No description provided.