◐ Shell
reader mode source ↗
Skip to content

gh-103921: Document PEP 695#104642

Merged
JelleZijlstra merged 69 commits into
python:mainfrom
JelleZijlstra:pep695docs
May 26, 2023
Merged

gh-103921: Document PEP 695#104642
JelleZijlstra merged 69 commits into
python:mainfrom
JelleZijlstra:pep695docs

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot mentioned this pull request May 19, 2023
Closed
9 tasks
@hugovk

hugovk commented May 19, 2023

Copy link
Copy Markdown
Member

You could add this PEP to the release highlights: https://docs.python.org/3.12/whatsnew/3.12.html#summary-release-highlights

AlexWaygood
AlexWaygood reviewed May 19, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I'd like us to explicitly state somewhere that typing.TypeAliasType is not the type of typing.TypeAlias (and that in fact, they basically don't compose at all). I feel like this will inevitably cause confusion otherwise.

JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request May 19, 2023
@JelleZijlstra
pythongh-103921: Rename "type" header in argparse docs …
6dae39a 
This allows :keyword:`type` to link to docs for the new `type`
statement (being written in pythongh-104642) instead of to this header
in the argparse docs.
@JelleZijlstra JelleZijlstra mentioned this pull request May 19, 2023
Merged
JelleZijlstra added a commit that referenced this pull request May 19, 2023
@JelleZijlstra
gh-103921: Rename "type" header in argparse docs (#104654) …
ab8f546 
This allows :keyword:`type` to link to docs for the new `type`
statement (being written in gh-104642) instead of to this header
in the argparse docs.
@JelleZijlstra JelleZijlstra mentioned this pull request May 19, 2023
Closed
178 hidden items Load more…
@carljm carljm mentioned this pull request May 26, 2023
Merged
AlexWaygood
AlexWaygood approved these changes May 26, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Other than #104642 (comment) and one tiny last nit, this looks fantastic. Thanks for the huge amount of effort here, and for putting up with my many rounds of review!

@JelleZijlstra JelleZijlstra merged commit 060277d into python:main May 26, 2023
@miss-islington

miss-islington commented May 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the pep695docs branch May 26, 2023 17:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2023
@JelleZijlstra @AlexWaygood @miss-islington
pythongh-103921: Document PEP 695 (pythonGH-104642) …
8fd4ab8 
(cherry picked from commit 060277d)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot

bedevere-bot commented May 26, 2023

Copy link
Copy Markdown

GH-104989 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 26, 2023
@carljm

carljm commented May 26, 2023

Copy link
Copy Markdown
Member

🎉

@AlexWaygood

AlexWaygood commented May 26, 2023

Copy link
Copy Markdown
Member

🥳🚀

JelleZijlstra added a commit that referenced this pull request May 26, 2023
@miss-islington @JelleZijlstra @AlexWaygood
[3.12] gh-103921: Document PEP 695 (GH-104642) (#104989) …
dcee0aa 
(cherry picked from commit 060277d)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request May 27, 2023
@JelleZijlstra
[3.11] pythongh-103921: Document PEP 695 (pythonGH-104642) …
0428d38 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>.
(cherry picked from commit 060277d)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra mentioned this pull request May 27, 2023
Merged
@bedevere-bot

bedevere-bot commented May 27, 2023

Copy link
Copy Markdown

GH-105007 is a backport of this pull request to the 3.11 branch.

JelleZijlstra added a commit that referenced this pull request May 27, 2023
@JelleZijlstra @AlexWaygood
[3.11] gh-103921: Improve typing documentation (GH-104642) (#105007) …
d34e58a 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
Closed
@AlexWaygood AlexWaygood mentioned this pull request Aug 31, 2024
Merged
@AA-Turner AA-Turner mentioned this pull request Oct 19, 2024
Closed
@picnixz picnixz mentioned this pull request May 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm left review comments

@hugovk hugovk hugovk left review comments

@gvanrossum gvanrossum gvanrossum left review comments

@AA-Turner AA-Turner AA-Turner left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@markshannon markshannon Awaiting requested review from markshannon

+1 more reviewer

@Gobot1234 Gobot1234 Gobot1234 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@JelleZijlstra @hugovk @miss-islington @bedevere-bot @carljm @AlexWaygood @gvanrossum @AA-Turner @Gobot1234